fix(web): name the chat history settings trigger - #40246
Closed
lyzno1 wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40246 +/- ##
=======================================
Coverage 86.41% 86.42%
=======================================
Files 5107 5107
Lines 290731 290750 +19
Branches 57917 57923 +6
=======================================
+ Hits 251245 251268 +23
+ Misses 34545 34541 -4
Partials 4941 4941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Closing as superseded by the consolidated owner PR #40341, which covers both chat ViewFormDropdown variants with action-oriented names and expanded-state tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavior contract
Scope
Only the chat-with-history
ViewFormDropdownimplementation and its focused test.The embedded-chat implementation is a separate owner already covered by #40199; this PR does not depend on or modify that implementation.
Test evidence
The updated tests failed first because the existing trigger had button role but an empty accessible name. After the production change, all 3 tests pass while continuing to cover open, close, multiple form items, and visual action state.
Visual regression
The production diff only adds
aria-labelandaria-hiddenattributes. Elements, class names, styles, dimensions, order, pointer behavior, and open-state rendering are unchanged.The two existing icon migration warnings are deliberately not folded into this PR because that would require a separate visual validation boundary.
Verification
pnpm exec vp test run app/components/base/chat/chat-with-history/inputs-form/__tests__/view-form-dropdown.spec.tsx— 3/3vp check— 0 errorsnode scripts/lint-a11y.mjs app/components/base/chat/chat-with-history/inputs-form/view-form-dropdown.tsxpnpm check— 0 errors, existing warnings onlygit diff --checkStack
Base:
mainThis is a single-layer, independently reviewable and revertible PR.