Skip to content

fix(web): name the chat history settings trigger #40246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lyzno1 wants to merge 1 commit into from
Closed

fix(web): name the chat history settings trigger #40246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .../components/base/chat/chat-with-history/inputs-form/__tests__/view-form-dropdown.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ describe('ViewFormDropdown', () => {
expect(screen.queryByText('share.chat.chatSettingsTitle')).not.toBeInTheDocument()

// Find trigger (ActionButton renders a button)
const trigger = screen.getByRole('button')
const trigger = screen.getByRole('button', { name: 'share.chat.chatSettingsTitle' })
expect(trigger).toBeInTheDocument()

// Open dropdown
Expand All @@ -90,7 +90,7 @@ describe('ViewFormDropdown', () => {

const user = userEvent.setup()
render(<ViewFormDropdown />)
await user.click(screen.getByRole('button'))
await user.click(screen.getByRole('button', { name: 'share.chat.chatSettingsTitle' }))

expect(screen.getByText('Text Form')).toBeInTheDocument()
expect(screen.getByText('Num Form')).toBeInTheDocument()
Expand All @@ -99,7 +99,7 @@ describe('ViewFormDropdown', () => {
it('applies correct state to ActionButton when open', async () => {
const user = userEvent.setup()
render(<ViewFormDropdown />)
const trigger = screen.getByRole('button')
const trigger = screen.getByRole('button', { name: 'share.chat.chatSettingsTitle' })

// closed state
expect(trigger).not.toHaveClass('action-btn-hover')
Expand Down
3 changes: 2 additions & 1 deletion web/app/components/base/chat/chat-with-history/inputs-form/view-form-dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@ const ViewFormDropdown = () => {
render={(props, state) => (
<ActionButton
{...props}
aria-label={t(($) => $['chat.chatSettingsTitle'], { ns: 'share' })}
size="l"
state={state.open ? ActionButtonState.Hover : ActionButtonState.Default}
>
<RiChatSettingsLine className="h-4.5 w-4.5" />
<RiChatSettingsLine aria-hidden="true" className="h-4.5 w-4.5" />
</ActionButton>
)}
/>
Expand Down