Skip to content

fix(web): name dataset configuration actions - #40254

Merged
lyzno1 merged 1 commit into
mainfrom
codex/a11y-dataset-config-actions
Aug 10, 2026
Merged

fix(web): name dataset configuration actions#40254
lyzno1 merged 1 commit into
mainfrom
codex/a11y-dataset-config-actions

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Give the dataset configuration card edit and remove actions explicit accessible names.
  • Hide the Remix icons from the accessibility tree because the button names now own the semantics.
  • Query the actions by role and accessible name in the owner tests instead of relying on DOM order.

Behavior contract

  • Assistive technology identifies the two icon-only actions as Edit and Remove.
  • Editing still opens the settings drawer, saving still closes it, and the mobile overlay behavior remains covered.
  • Removing still invokes the existing callback, including the existing destructive hover state.

Visual regression

No visual change is expected. This PR does not change elements, classes, styles, layout, node order, or event handlers; it only adds ARIA attributes and strengthens test queries.

The two existing prefer-tailwind-icons warnings in this component are intentionally left unchanged so an icon implementation migration can be reviewed separately.

Validation

  • pnpm exec vp check web/app/components/app/configuration/dataset-config/card-item/index.tsx web/app/components/app/configuration/dataset-config/card-item/tests/index.spec.tsx
  • node scripts/lint-a11y.mjs web/app/components/app/configuration/dataset-config/card-item/index.tsx
  • pnpm exec vp test run web/app/components/app/configuration/dataset-config/card-item/tests/index.spec.tsx (5/5)
  • pnpm check (0 errors, 2059 existing warnings)

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.43%. Comparing base (7522ae1) to head (d658142).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40254      +/-   ##
==========================================
- Coverage   86.47%   86.43%   -0.05%     
==========================================
  Files        5264     5107     -157     
  Lines      294867   290742    -4125     
  Branches    59029    57924    -1105     
==========================================
- Hits       254976   251291    -3685     
+ Misses      34950    34510     -440     
  Partials     4941     4941              
Flag Coverage Δ
cli ?
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1
lyzno1 marked this pull request as ready for review August 9, 2026 15:47
@lyzno1
lyzno1 requested review from iamjoel and zxhlyh as code owners August 9, 2026 15:47
@lyzno1
lyzno1 marked this pull request as draft August 9, 2026 15:50
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 9, 2026
@lyzno1
lyzno1 force-pushed the codex/a11y-dataset-config-actions branch from 662c356 to d658142 Compare August 9, 2026 15:56
@lyzno1
lyzno1 marked this pull request as ready for review August 9, 2026 16:14
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 10, 2026
@lyzno1
lyzno1 added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit 5de4e5b Aug 10, 2026
42 checks passed
@lyzno1
lyzno1 deleted the codex/a11y-dataset-config-actions branch August 10, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants