Skip to content

fix(web): name dataset configuration actions #40254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyzno1 merged 1 commit into from
Aug 10, 2026
+28 −9
Merged

fix(web): name dataset configuration actions #40254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions web/app/components/app/configuration/dataset-config/card-item/__tests__/index.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,14 @@ describe('dataset-config/card-item', () => {
renderItem(dataset)

const card = screen.getByText(dataset.name).closest('.group') as HTMLElement
const actionButtons = within(card).getAllByRole('button', { hidden: true })
const editButton = within(card).getByRole('button', {
name: 'common.operation.edit',
hidden: true,
})
const removeButton = within(card).getByRole('button', {
name: 'common.operation.remove',
hidden: true,
})

expect(screen.getByText(dataset.name))!.toBeInTheDocument()
expect(
Expand All @@ -160,7 +167,8 @@ describe('dataset-config/card-item', () => {
),
)!.toBeInTheDocument()
expect(screen.getByText('dataset.externalTag'))!.toBeInTheDocument()
expect(actionButtons).toHaveLength(2)
expect(editButton).toBeInTheDocument()
expect(removeButton).toBeInTheDocument()
})

it('should open settings drawer from edit action and close after saving', async () => {
Expand All @@ -169,8 +177,11 @@ describe('dataset-config/card-item', () => {
const { onSave } = renderItem(dataset)

const card = screen.getByText(dataset.name).closest('.group') as HTMLElement
const [editButton] = within(card).getAllByRole('button', { hidden: true })
await user.click(editButton!)
const editButton = within(card).getByRole('button', {
name: 'common.operation.edit',
hidden: true,
})
await user.click(editButton)

expect(await screen.findByText('Mock settings modal'))!.toBeInTheDocument()
fireEvent.click(await screen.findByText('Save changes'))
Expand All @@ -189,8 +200,10 @@ describe('dataset-config/card-item', () => {
const { onRemove } = renderItem(dataset)

const card = screen.getByText(dataset.name).closest('.group') as HTMLElement
const buttons = within(card).getAllByRole('button', { hidden: true })
const deleteButton = buttons.at(-1)!
const deleteButton = within(card).getByRole('button', {
name: 'common.operation.remove',
hidden: true,
})

expect(deleteButton.className).not.toContain('action-btn-destructive')

Expand Down Expand Up @@ -225,8 +238,11 @@ describe('dataset-config/card-item', () => {
renderItem(dataset)

const card = screen.getByText(dataset.name).closest('.group') as HTMLElement
const [editButton] = within(card).getAllByRole('button', { hidden: true })
await user.click(editButton!)
const editButton = within(card).getByRole('button', {
name: 'common.operation.edit',
hidden: true,
})
await user.click(editButton)
expect(screen.getByText('Mock settings modal'))!.toBeInTheDocument()

const overlay = [...document.querySelectorAll('[class]')].find(
Expand Down
5 changes: 4 additions & 1 deletion web/app/components/app/configuration/dataset-config/card-item/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,22 +74,25 @@ const Item: FC<ItemProps> = ({ config, onSave, onRemove, readonly = false, edita
<div className="ml-2 hidden shrink-0 items-center space-x-1 group-hover:flex">
{editable && !readonly && (
<ActionButton
aria-label={t(($) => $['operation.edit'], { ns: 'common' })}
onClick={(e) => {
e.stopPropagation()
setShowSettingsModal(true)
}}
>
<RiEditLine className="size-4 shrink-0 text-text-tertiary" />
<RiEditLine aria-hidden="true" className="size-4 shrink-0 text-text-tertiary" />
</ActionButton>
)}
{!readonly && (
<ActionButton
aria-label={t(($) => $['operation.remove'], { ns: 'common' })}
onClick={() => onRemove(config.id)}
state={isDeleting ? ActionButtonState.Destructive : ActionButtonState.Default}
onMouseEnter={() => setIsDeleting(true)}
onMouseLeave={() => setIsDeleting(false)}
>
<RiDeleteBinLine
aria-hidden="true"
className={cn(
'size-4 shrink-0 text-text-tertiary',
isDeleting && 'text-text-destructive',
Expand Down