Skip to content

fix(web): name endpoint card actions - #40260

Draft
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-endpoint-card-actions
Draft

fix(web): name endpoint card actions#40260
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-endpoint-card-actions

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Give the endpoint card edit and delete icon buttons explicit accessible names.
  • Keep the existing copy action name and decorative CSS icons unchanged.
  • Replace nine positional button queries in the owner suite with Edit, Delete, and Copy role-and-name queries.

Behavior contract

  • Assistive technology identifies the endpoint card actions as Edit, Delete, and Copy.
  • Edit still opens the endpoint modal and preserves save, cancel, success, and failure flows.
  • Delete still opens confirmation and preserves confirm, cancel, success, and failure flows.
  • Copy still copies the visible endpoint URL and resets its existing copied state.
  • Enable and disable behavior remains independent and covered.

Visual regression

No visual change is expected. This PR does not change elements, classes, styles, layout, node order, visibility rules, or event handlers; it only adds ARIA labels to two existing buttons and strengthens test queries.

The existing array-key and CopyCheck icon warnings are intentionally left unchanged for separate review.

Validation

  • pnpm exec vp check app/components/plugins/plugin-detail-panel/endpoint-card.tsx app/components/plugins/plugin-detail-panel/tests/endpoint-card.spec.tsx (0 errors, 2 existing warnings)
  • node scripts/lint-a11y.mjs app/components/plugins/plugin-detail-panel/endpoint-card.tsx
  • pnpm exec vp test run app/components/plugins/plugin-detail-panel/tests/endpoint-card.spec.tsx (20/20)
  • pnpm check (0 errors, 2059 existing warnings)

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.42%. Comparing base (e036075) to head (9bd74c1).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #40260   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files        5107     5107           
  Lines      290731   290751   +20     
  Branches    57917    57923    +6     
=======================================
+ Hits       251245   251269   +24     
+ Misses      34545    34541    -4     
  Partials     4941     4941           
Flag Coverage Δ
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant