Skip to content

fix(web): name endpoint card actions #40260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyzno1 merged 2 commits into from
Aug 10, 2026
+40 −20
Merged

fix(web): name endpoint card actions #40260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3a8596
fix(web): name endpoint card actions
lyzno1 Aug 9, 2026
35bde8f
fix(web): keep endpoint actions keyboard reachable
lyzno1 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 34 additions & 18 deletions web/app/components/plugins/plugin-detail-panel/__tests__/endpoint-card.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { EndpointListItem, PluginDetail } from '../../types'
import { act, fireEvent, render, screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import EndpointCard from '../endpoint-card'

Expand All @@ -10,6 +11,10 @@ const mockDeleteEndpoint = vi.fn()
const mockUpdateEndpoint = vi.fn()
const mockToastNotify = vi.fn()

const getEditButton = () => screen.getByRole('button', { name: 'common.operation.edit' })
const getDeleteButton = () => screen.getByRole('button', { name: 'common.operation.delete' })
const getCopyButton = () => screen.getByRole('button', { name: 'common.operation.copy' })

vi.mock('@langgenius/dify-ui/toast', () => ({
toast: Object.assign(
(message: string, options?: { type?: string }) =>
Expand Down Expand Up @@ -212,6 +217,26 @@ describe('EndpointCard', () => {
})

describe('User Interactions', () => {
it('should reach endpoint actions through the tab order', async () => {
const user = userEvent.setup()
render(
<EndpointCard
pluginDetail={mockPluginDetail}
data={mockEndpointData}
handleChange={mockHandleChange}
/>,
)

await user.tab()
expect(getEditButton()).toHaveFocus()

await user.tab()
expect(getDeleteButton()).toHaveFocus()

await user.keyboard('{Enter}')
expect(screen.getByText('plugin.detailPanel.endpointDeleteTip')).toBeInTheDocument()
})

it('should show disable confirm when switching off', () => {
render(
<EndpointCard
Expand Down Expand Up @@ -251,8 +276,7 @@ describe('EndpointCard', () => {
/>,
)

const allButtons = screen.getAllByRole('button')
fireEvent.click(allButtons[1]!)
fireEvent.click(getDeleteButton())

expect(screen.getByText('plugin.detailPanel.endpointDeleteTip'))!.toBeInTheDocument()
})
Expand All @@ -266,8 +290,7 @@ describe('EndpointCard', () => {
/>,
)

const allButtons = screen.getAllByRole('button')
fireEvent.click(allButtons[1]!)
fireEvent.click(getDeleteButton())
fireEvent.click(screen.getByRole('button', { name: 'common.operation.confirm' }))

expect(mockDeleteEndpoint).toHaveBeenCalledWith('ep-1')
Expand All @@ -282,8 +305,7 @@ describe('EndpointCard', () => {
/>,
)

const allButtons = screen.getAllByRole('button')
fireEvent.click(allButtons[0]!)
fireEvent.click(getEditButton())

expect(screen.getByTestId('endpoint-modal'))!.toBeInTheDocument()
})
Expand All @@ -297,8 +319,7 @@ describe('EndpointCard', () => {
/>,
)

const allButtons = screen.getAllByRole('button')
fireEvent.click(allButtons[0]!)
fireEvent.click(getEditButton())
fireEvent.click(screen.getByTestId('modal-save'))

expect(mockUpdateEndpoint).toHaveBeenCalled()
Expand All @@ -316,8 +337,7 @@ describe('EndpointCard', () => {
/>,
)

const allButtons = screen.getAllByRole('button')
fireEvent.click(allButtons[2]!)
fireEvent.click(getCopyButton())

act(() => {
vi.advanceTimersByTime(2000)
Expand Down Expand Up @@ -386,8 +406,7 @@ describe('EndpointCard', () => {
/>,
)

const allButtons = screen.getAllByRole('button')
fireEvent.click(allButtons[1]!)
fireEvent.click(getDeleteButton())
expect(screen.getByText('plugin.detailPanel.endpointDeleteTip'))!.toBeInTheDocument()

fireEvent.click(screen.getByRole('button', { name: 'common.operation.cancel' }))
Expand All @@ -403,8 +422,7 @@ describe('EndpointCard', () => {
/>,
)

const allButtons = screen.getAllByRole('button')
fireEvent.click(allButtons[0]!)
fireEvent.click(getEditButton())
expect(screen.getByTestId('endpoint-modal'))!.toBeInTheDocument()

fireEvent.click(screen.getByTestId('modal-cancel'))
Expand Down Expand Up @@ -456,8 +474,7 @@ describe('EndpointCard', () => {
/>,
)

const allButtons = screen.getAllByRole('button')
fireEvent.click(allButtons[1]!)
fireEvent.click(getDeleteButton())
fireEvent.click(screen.getByRole('button', { name: 'common.operation.confirm' }))

expect(mockDeleteEndpoint).toHaveBeenCalled()
Expand All @@ -472,8 +489,7 @@ describe('EndpointCard', () => {
/>,
)

const allButtons = screen.getAllByRole('button')
fireEvent.click(allButtons[0]!)
fireEvent.click(getEditButton())

expect(screen.getByTestId('endpoint-modal'))!.toBeInTheDocument()

Expand Down
8 changes: 6 additions & 2 deletions web/app/components/plugins/plugin-detail-panel/endpoint-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,15 @@ const EndpointCard = ({ pluginDetail, data, handleChange }: Props) => {
<span aria-hidden className="i-ri-login-circle-line size-4" />
<div>{data.name}</div>
</div>
<div className="hidden items-center group-hover:flex">
<ActionButton onClick={showEndpointModalConfirm}>
<div className="flex w-0 items-center overflow-hidden opacity-0 group-hover:w-auto group-hover:overflow-visible group-hover:opacity-100 focus-within:w-auto focus-within:overflow-visible focus-within:opacity-100">
<ActionButton
aria-label={t(($) => $['operation.edit'], { ns: 'common' })}
onClick={showEndpointModalConfirm}
>
<span aria-hidden className="i-ri-edit-line size-4" />
</ActionButton>
<ActionButton
aria-label={t(($) => $['operation.delete'], { ns: 'common' })}
onClick={showDeleteConfirm}
className="text-text-tertiary hover:bg-state-destructive-hover hover:text-text-destructive"
>
Expand Down