Skip to content

test(web): query core credential actions by name - #40266

Draft
lyzno1 wants to merge 1 commit into
codex/a11y-plugin-credential-actionsfrom
codex/a11y-plugin-credential-action-tests
Draft

test(web): query core credential actions by name#40266
lyzno1 wants to merge 1 commit into
codex/a11y-plugin-credential-actionsfrom
codex/a11y-plugin-credential-action-tests

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Query the core plugin credential Delete, Rename, and Edit flows by role and accessible name instead of SVG class, button order, or generic icon traversal.
  • Remove conditional branches that allowed those tests to pass without finding or activating the intended action.
  • Keep this PR test-only and scoped to the primary confirmation, rename, edit modal, close, and remove flows.

Behavior contract

  • Delete tests must activate Delete and observe the confirmation, cancellation, mutation, notification, and update callback paths.
  • Rename tests must activate Rename and observe the textbox, save mutation, notification, and update callback paths.
  • Edit tests must activate Edit and observe the modal open, close/reset, and remove-to-confirmation paths.
  • This PR depends on fix(web): name plugin credential actions #40265, which supplies the accessible names used by these locators.

Visual regression

This is a test-only PR. It has no production bundle, DOM, CSS, layout, interaction, or runtime visual effect.

Validation

  • pnpm exec vp check app/components/plugins/plugin-auth/authorized/tests/index.spec.tsx (0 errors, 0 warnings)
  • pnpm exec vp test run app/components/plugins/plugin-auth/authorized/tests/index.spec.tsx (62/62)
  • pnpm check (0 errors, 2059 existing warnings)
  • git diff codex/a11y-plugin-credential-actions --stat (1 test file; 118 insertions, 338 deletions)

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant