Skip to content

fix: parse grouped skills list output#1188

Draft
nguyenngothuong wants to merge 1 commit into
larksuite:mainfrom
nguyenngothuong:codex/fix-skills-list-detection
Draft

fix: parse grouped skills list output#1188
nguyenngothuong wants to merge 1 commit into
larksuite:mainfrom
nguyenngothuong:codex/fix-skills-list-detection

Conversation

@nguyenngothuong
Copy link
Copy Markdown

Summary

Fix the incremental skills sync local-skill detection when npx skills ls -g prints grouped, indented human-readable output. The parser now recognizes indented skill rows without treating category headings as skills.

Changes

Test Plan

  • Unit tests pass: go test ./internal/skillscheck -count=1
  • Unit tests pass: go test ./cmd/update -count=1
  • Unit tests pass: go test ./internal/skillscheck ./cmd/update -count=1
  • Manual local verification confirms the lark-cli update flow works as expected

Related Issues

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 54c27fde-7384-49fd-98b6-a81f950102ff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lark-cli update incremental skills sync does not detect installed skills from grouped skills ls output

2 participants