Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions internal/skillscheck/sync.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,12 @@ func parseGlobalSkillsList(lines []string) []string {
continue
}

// Skip indented lines (Agents: ...)
if strings.HasPrefix(line, " ") || strings.HasPrefix(line, "\t") {
continue
}

// Extract skill name, format is typically "skill-name /path/to/skill"
parts := strings.Fields(trimmed)
if len(parts) == 0 {
if len(parts) < 2 {
continue
}
if !looksLikeSkillPath(parts[1]) {
continue
}

Expand All @@ -106,6 +104,15 @@ func parseGlobalSkillsList(lines []string) []string {
return sortedKeys(seen)
}

func looksLikeSkillPath(s string) bool {
return strings.HasPrefix(s, "~/") ||
strings.HasPrefix(s, "/") ||
strings.HasPrefix(s, "./") ||
strings.HasPrefix(s, "../") ||
strings.Contains(s, `:\`) ||
strings.Contains(s, `/`)
}

// parseOfficialSkillsList parses the output of "npx -y skills add ... --list"
func parseOfficialSkillsList(lines []string) []string {
seen := map[string]bool{}
Expand Down
24 changes: 24 additions & 0 deletions internal/skillscheck/sync_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,30 @@ yuanbao ~/.hermes/skills/yuanbao
}
}

func TestParseGlobalSkillsListWithGroupedIndentedSkills(t *testing.T) {
input := `Global Skills

General
lark-apps ~/.agents/skills/lark-apps
lark-base ~/.agents/skills/lark-base
lark-contact ~/.agents/skills/lark-contact

Document
lark-doc ~/.agents/skills/lark-doc
lark-openapi-explorer ~/.agents/skills/lark-openapi-explorer

Knowledge Base
lark-wiki /Users/me/.agents/skills/lark-wiki

Tip: Use the -y flag to run in non-interactive mode (for CI and AI agents).
`
got := ParseSkillsList(input)
want := []string{"lark-apps", "lark-base", "lark-contact", "lark-doc", "lark-openapi-explorer", "lark-wiki"}
if !reflect.DeepEqual(got, want) {
t.Fatalf("ParseSkillsList() (grouped Global Skills) = %#v, want %#v", got, want)
}
}

func TestParseGlobalSkillsListWithANSI(t *testing.T) {
input := "\x1b[1mGlobal Skills\x1b[0m\n\n" +
"\x1b[36mlark-calendar\x1b[0m \x1b[38;5;102m~/.agents/skills/lark-calendar\x1b[0m\n" +
Expand Down
Loading