fix: crash on CreateOpenChatActivity when chanelId is empty#187
Open
TinhHuynh wants to merge 1 commit intoline:masterfrom
Open
fix: crash on CreateOpenChatActivity when chanelId is empty#187TinhHuynh wants to merge 1 commit intoline:masterfrom
TinhHuynh wants to merge 1 commit intoline:masterfrom
Conversation
|
|
Author
|
Hi @YkSix, could you please review this PR? This PR helps address #185. Similar issues have been observed in other SDKs as well (for example, Stripe). In Stripe’s case, the problem was resolved by validating required arguments before executing the main logic (see stripe/stripe-android#12136, stripe/stripe-android#12138, etc.). The approach taken in this PR follows the same pattern. |
|
@YkSix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.