Skip to content

fix: crash on CreateOpenChatActivity when chanelId is empty #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TinhHuynh wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −2
Open

fix: crash on CreateOpenChatActivity when chanelId is empty #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions line-sdk/src/main/java/com/linecorp/linesdk/openchat/ui/CreateOpenChatActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,13 @@ import com.linecorp.linesdk.databinding.ActivityCreateOpenChatBinding
import com.linecorp.linesdk.openchat.OpenChatRoomInfo

class CreateOpenChatActivity : AppCompatActivity() {
private enum class CreateOpenChatStep { ChatroomInfo, UserProfile }
private val channelId: String by lazy { intent.getStringExtra(ARG_CHANNEL_ID).orEmpty() }

private enum class CreateOpenChatStep { ChatroomInfo, UserProfile }

private lateinit var binding: ActivityCreateOpenChatBinding

private val lineApiClient: LineApiClient by lazy {
val channelId = intent.getStringExtra(ARG_CHANNEL_ID).orEmpty()
LineApiClientBuilder(this, channelId)
.build()
}
Expand All @@ -38,6 +39,20 @@ class CreateOpenChatActivity : AppCompatActivity() {
private var currentStep = CreateOpenChatStep.ChatroomInfo

override fun onCreate(savedInstanceState: Bundle?) {
if (channelId.isBlank()) {
super.onCreate(null)

setResult(
RESULT_CANCELED,
Intent().putExtra(
ARG_ERROR_RESULT,
LineApiError("Missing channelId. Start CreateOpenChatActivity via createIntent(context, channelId).")
)
)
finish()
return
}

super.onCreate(savedInstanceState)
binding = ActivityCreateOpenChatBinding.inflate(layoutInflater)
setContentView(binding.root)
Expand Down