繁體中文 (zh_TW), 简体中文 (zh_CN) - #1
Conversation
|
For product names or specific terms that should remain in English, consider excluding them from the translation JSON or maintaining a separate list/section for these terms. This would help translators avoid ambiguity, as it is currently difficult to determine the intended usage context of each term from the JSON entries alone. |
|
Thank you so much! I will get this reviewed ASAP! |
Restores the six keys listed in context/english-only.txt — "Custom Site" and friends in zh_CN, "Wall of Love" in both. The validator gates these, so the check was failing. zh_TW also had 折扣码 with the simplified 码 one line above 折扣碼, and "Have a coupon code?" was still on 優惠碼 while the other three moved to 折扣碼 — all four now agree. Reverts three where the original read better: 佈署中 breaks the 開通 provisioning family used by the other eight Provision* strings, 已進行開通 loses the "started" tense, and 請於稍候 puts 於 in front of a verb.
|
Thank you — this is a genuinely useful first contribution, and most of it went in as written. I pushed one commit on top rather than sending you round again, so you can see exactly what changed and why. Restored six keys that stay English.
Made the coupon term consistent. You moved three of the four coupon strings to Reverted three where the original read better:
Kept as you wrote them: One thing that was not your fault: the check never ran on this PR. GitHub holds workflows from first-time contributors until a maintainer releases them, so it sat pending rather than reporting the six failures. That setting is being changed so the next contributor gets real feedback immediately. Heads up on one follow-up: a batch of strings in these catalogues turn out to be admin-panel labels that only I ever see ( Merged — thanks again. |
|
This is live on linkrobins.com now — your corrections went out with today's deploy, so the dashboard renders them for anyone signed in with 简体中文 or 繁體中文 selected. Credit is on the commit that carried them across. The admin-panel labels I mentioned are gone too: nine catalogues went from 962 strings to 944, and Thanks again for taking the time on both variants. The Traditional pass in particular was the one I had least confidence in, since it shipped without a native speaker reading it. |
PR #1 shortened 確認知悉 to 確認 on the button and badge but left 已知悉 in the confirmation dialog, so one action read three ways across five strings. 確認 alone is also the generic "Confirm", which is a different thing from acknowledging an incident — acknowledging means "seen it, stop alerting me". Standardises on the contributor's own word rather than restoring the clunkier original: they had already written 已知悉 in the dialog, and that string is untouched here.
zh_CN and zh_TW still carried "first pass, unreviewed" after PR #1, which is backwards: they are now the only two a native speaker has read, and the flag was pointing contributors at the files that need it least while ja/ko/ru/pl carried no flag at all.
Language: 繁體中文 (zh_TW), 简体中文 (zh_CN)
What changed: Improved translation consistency and wording in both Traditional and Simplified Chinese.
python3 tools/validate.py zh_TWpassespython3 tools/validate.py zh_CNpasses