Skip to content

繁體中文 (zh_TW), 简体中文 (zh_CN) - #1

Merged
karl-bullock merged 5 commits into
linkrobins:mainfrom
efast1568:main
Jul 28, 2026
Merged

繁體中文 (zh_TW), 简体中文 (zh_CN)#1
karl-bullock merged 5 commits into
linkrobins:mainfrom
efast1568:main

Conversation

@efast1568

@efast1568 efast1568 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Language: 繁體中文 (zh_TW), 简体中文 (zh_CN)

What changed: Improved translation consistency and wording in both Traditional and Simplified Chinese.

  • python3 tools/validate.py zh_TW passes
  • python3 tools/validate.py zh_CN passes

@efast1568

Copy link
Copy Markdown
Contributor Author

For product names or specific terms that should remain in English, consider excluding them from the translation JSON or maintaining a separate list/section for these terms.

This would help translators avoid ambiguity, as it is currently difficult to determine the intended usage context of each term from the JSON entries alone.

@karl-bullock

Copy link
Copy Markdown
Member

Thank you so much! I will get this reviewed ASAP!

Restores the six keys listed in context/english-only.txt — "Custom Site"
and friends in zh_CN, "Wall of Love" in both. The validator gates these,
so the check was failing.

zh_TW also had 折扣码 with the simplified 码 one line above 折扣碼, and
"Have a coupon code?" was still on 優惠碼 while the other three moved to
折扣碼 — all four now agree.

Reverts three where the original read better: 佈署中 breaks the 開通
provisioning family used by the other eight Provision* strings, 已進行開通
loses the "started" tense, and 請於稍候 puts 於 in front of a verb.
@karl-bullock
karl-bullock merged commit f5230a5 into linkrobins:main Jul 28, 2026
1 check passed
@karl-bullock

Copy link
Copy Markdown
Member

Thank you — this is a genuinely useful first contribution, and most of it went in as written.

I pushed one commit on top rather than sending you round again, so you can see exactly what changed and why.

Restored six keys that stay English. Custom Site, Custom Site Hosting, Custom site, Custom websites in zh_CN, and Wall of Love in both files. These are product names listed in context/english-only.txt — the validator enforces them. Leaving English inside a Chinese catalogue looks like an oversight, so this was a reasonable thing to want to fix; the rule just isn't visible from the file itself.

折扣码折扣碼. A simplified had slipped into zh_TW one line above the correct 折扣碼.

Made the coupon term consistent. You moved three of the four coupon strings to 折扣碼 but Have a coupon code? was still on 優惠碼. I moved the fourth to match your choice, so all four now agree.

Reverted three where the original read better:

  • 你的新論壇正在佈署中 — the other eight Provision* strings all use 開通, so this one splits the family; 部署 is also the standard spelling.
  • 已進行開通 — the English is "Provisioning started", which 已開始開通 carries and 已進行 doesn't.
  • 請於稍候查收郵件 wants a time noun after it, but 稍候 is a verb.

Kept as you wrote them: 心跳訊號 / 未收到心跳訊號 is a clear improvement on 心跳遺漏, and 在线率监测 fixes a mismatch with :value 在线率 that I had missed. 留客優惠, 只差一步 and the Acknowledge wording are yours — you speak the language, and the guidelines settle those in your favour.

One thing that was not your fault: the check never ran on this PR. GitHub holds workflows from first-time contributors until a maintainer releases them, so it sat pending rather than reporting the six failures. That setting is being changed so the next contributor gets real feedback immediately.

Heads up on one follow-up: a batch of strings in these catalogues turn out to be admin-panel labels that only I ever see (Captcha, Cron job, Webhooks and similar). I am removing them from all nine catalogues shortly so nobody spends time translating screens that are not customer-facing. Nothing you translated here is affected.

Merged — thanks again.

@karl-bullock

Copy link
Copy Markdown
Member

This is live on linkrobins.com now — your corrections went out with today's deploy, so the dashboard renders them for anyone signed in with 简体中文 or 繁體中文 selected. Credit is on the commit that carried them across.

The admin-panel labels I mentioned are gone too: nine catalogues went from 962 strings to 944, and context/english-only.txt lost Horizon and MCP along with them. Nothing you translated was affected, but if you pull the repo again you will see those rows missing from context/strings.csv — that is why.

Thanks again for taking the time on both variants. The Traditional pass in particular was the one I had least confidence in, since it shipped without a native speaker reading it.

karl-bullock added a commit that referenced this pull request Jul 28, 2026
PR #1 shortened 確認知悉 to 確認 on the button and badge but left 已知悉 in
the confirmation dialog, so one action read three ways across five
strings. 確認 alone is also the generic "Confirm", which is a different
thing from acknowledging an incident — acknowledging means "seen it, stop
alerting me".

Standardises on the contributor's own word rather than restoring the
clunkier original: they had already written 已知悉 in the dialog, and that
string is untouched here.
karl-bullock added a commit that referenced this pull request Jul 28, 2026
zh_CN and zh_TW still carried "first pass, unreviewed" after PR #1, which
is backwards: they are now the only two a native speaker has read, and
the flag was pointing contributors at the files that need it least while
ja/ko/ru/pl carried no flag at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants