[PW_SID:1080868] bpf, arm64/riscv: Remove redundant icache flush after pack allocator finalize by linux-riscv-bot · Pull Request #1763 · linux-riscv/linux

linux-riscv-bot · 2026-04-13T20:37:39Z

PR for series 1080868 applied to workflow__riscv__fixes

Name: bpf, arm64/riscv: Remove redundant icache flush after pack allocator finalize
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1080868
Version: 2

…finalize bpf_flush_icache() calls flush_icache_range() to clean the data cache and invalidate the instruction cache for the JITed code region. However, since commit 1dad391 ("bpf, arm64: use bpf_prog_pack for memory management"), this flush is redundant. bpf_jit_binary_pack_finalize() copies the JITed instructions to the ROX region via bpf_arch_text_copy() -> aarch64_insn_copy() -> __text_poke(), and __text_poke() already calls flush_icache_range() on the written range. The subsequent bpf_flush_icache() repeats the same cache maintenance on an overlapping range, including an unnecessary second synchronous IPI to all CPUs via kick_all_cpus_sync(). Remove the redundant bpf_flush_icache() call and its now-unused definition. Fixes: 1dad391 ("bpf, arm64: use bpf_prog_pack for memory management") Acked-by: Song Liu <song@kernel.org> Signed-off-by: Puranjay Mohan <puranjay@kernel.org> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

…finalize bpf_flush_icache() calls flush_icache_range() to clean the data cache and invalidate the instruction cache for the JITed code region. However, since commit 48a8f78 ("bpf, riscv: use prog pack allocator in the BPF JIT"), this flush is redundant. bpf_jit_binary_pack_finalize() copies the JITed instructions to the ROX region via bpf_arch_text_copy() -> patch_text_nosync(), and patch_text_nosync() already calls flush_icache_range() on the written range. The subsequent bpf_flush_icache() repeats the same cache maintenance on an overlapping range. Remove the redundant bpf_flush_icache() call and its now-unused definition. Fixes: 48a8f78 ("bpf, riscv: use prog pack allocator in the BPF JIT") Acked-by: Song Liu <song@kernel.org> Signed-off-by: Puranjay Mohan <puranjay@kernel.org> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>

linux-riscv-bot · 2026-04-13T20:43:38Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 136.58 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:00:15Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 994.49 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:22:36Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1339.74 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:23:02Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.78 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:23:30Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.02 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:23:32Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.76 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:24:58Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 84.46 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:25:00Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:25:03Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:25:04Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:25:06Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.27 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:25:08Z

Patch 1: "[bpf-next,v2,1/2] bpf, arm64: Remove redundant bpf_flush_icache() after pack allocator finalize"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:27:39Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 135.92 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T21:46:08Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1107.05 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T22:13:04Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1614.44 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T22:13:31Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 24.80 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T22:13:58Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.12 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T22:14:01Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.92 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T22:15:26Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.53 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T22:15:28Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T22:15:30Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
kdoc
Desc: Detects for kdoc errors
Duration: 0.86 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T22:15:32Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T22:15:34Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.28 seconds
Result: PASS

linux-riscv-bot · 2026-04-13T22:15:36Z

Patch 2: "[bpf-next,v2,2/2] bpf, riscv: Remove redundant bpf_flush_icache() after pack allocator finalize"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

puranjaymohan added 2 commits April 13, 2026 20:37

linux-riscv-bot closed this Apr 21, 2026

linux-riscv-bot deleted the pw1080868 branch April 21, 2026 01:53

Conversation

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

linux-riscv-bot commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants