Skip to content

Update max_participants doc. Ingress participants do count, but Agents don't - #1715

Merged
biglittlebigben merged 2 commits into
mainfrom
benjamin/max_participants_doc
Aug 14, 2026
Merged

Update max_participants doc. Ingress participants do count, but Agents don't#1715
biglittlebigben merged 2 commits into
mainfrom
benjamin/max_participants_doc

Conversation

@biglittlebigben

Copy link
Copy Markdown
Contributor

No description provided.

@biglittlebigben
biglittlebigben requested a lite review from Copilot August 14, 2026 16:06
@changeset-bot

changeset-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9413f3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the protobuf API documentation/formatting around max_participants, clarifying participant types counted toward the limit and normalizing a few formatting inconsistencies in livekit_room.proto.

Changes:

  • Clarifies RoomConfiguration.max_participants comment to exclude Agent participants (and still exclude Egress).
  • Normalizes minor protobuf formatting (RPC signature spacing, deprecated option spacing, removes stray blank line).
Files not reviewed (1)
  • livekit/livekit_room.pb.go: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.


message RoomConfiguration {
string name = 1; // Used as ID, must be unique
string name = 1; // Used as ID, must be unique
@biglittlebigben
biglittlebigben merged commit 600c638 into main Aug 14, 2026
6 checks passed
@biglittlebigben
biglittlebigben deleted the benjamin/max_participants_doc branch August 14, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants