Skip to content

Update max_participants doc. Ingress participants do count, but Agents don't #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
biglittlebigben merged 2 commits into from
Aug 14, 2026
Merged

Update max_participants doc. Ingress participants do count, but Agents don't #1715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d654f2b
Update max_participants doc. Ingress participants do count, but Agent…
biglittlebigben Aug 14, 2026
9413f3e
generated protobuf
github-actions[bot] Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion livekit/livekit_room.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions protobufs/livekit_room.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ service RoomService {
rpc SendData(SendDataRequest) returns (SendDataResponse);

// Update room metadata, will cause updates to be broadcasted to everyone in the room, Requires `roomAdmin`
rpc UpdateRoomMetadata (UpdateRoomMetadataRequest) returns (Room);
rpc UpdateRoomMetadata(UpdateRoomMetadataRequest) returns (Room);

// Cloud-only
// Forward a connected participant's track(s) to another room. Requires `roomAdmin` and `destinationRoom`. The forwarding will
Expand Down Expand Up @@ -125,7 +125,6 @@ message RoomAgent {
repeated RoomAgentDispatch dispatches = 1;
}


message ListRoomsRequest {
// when set, will only return rooms with name match
repeated string names = 1;
Expand Down Expand Up @@ -222,7 +221,7 @@ message SendDataRequest {
bytes data = 2;
DataPacket.Kind kind = 3;
// mark deprecated
repeated string destination_sids = 4 [deprecated=true];
repeated string destination_sids = 4 [deprecated = true];
// when set, only forward to these identities
repeated string destination_identities = 6;
optional string topic = 5;
Expand All @@ -246,12 +245,12 @@ message UpdateRoomMetadataRequest {
}

message RoomConfiguration {
string name = 1; // Used as ID, must be unique
string name = 1; // Used as ID, must be unique
// number of seconds to keep the room open if no one joins
uint32 empty_timeout = 2;
// number of seconds to keep the room open after everyone leaves
uint32 departure_timeout = 3;
// limit number of participants that can be in a room, excluding Egress and Ingress participants
// limit number of participants that can be in a room, excluding Egress and Agent participants
uint32 max_participants = 4;
// metadata of room
string metadata = 11 [
Expand Down