feat(#28): add ServiceRegistry — centralise enrichment/classify/dedup/sort pipeline#44
Merged
feat(#28): add ServiceRegistry — centralise enrichment/classify/dedup/sort pipeline#44
Conversation
…fy/dedup/sort pipeline now centralised in ServiceRegistry; TransactionProcessingOrchestrator trimmed to group_by_iban only
…dary tests - ProcessorFactory.create_custom and BankStatementProcessorBuilder.build() now construct ServiceRegistry.from_config() and inject it via registry= kwarg, so the processor no longer builds its own registry internally - Fix wrong import of ChronologicalSortingStrategy (patterns.strategies → services.sorting_service) in service_registry.py - Add tests/services/test_service_registry.py with boundary tests covering from_config wiring, process_transaction_group pipeline, group_by_iban delegation, and escape hatches - Trim test_transaction_processing_orchestrator.py to group_by_iban only; removed tests for methods that moved to ServiceRegistry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces `ServiceRegistry` as the single wiring point for all transaction processing services (enrichment, classification, duplicate detection, sorting). Consolidates logic that was previously spread across `BankStatementProcessor` and `TransactionProcessingOrchestrator`, and trims the orchestrator to IBAN grouping only.
Changes
Note: `TransactionProcessingOrchestrator` is retained for backward compatibility — a follow-up issue will track its complete removal.
Type
Testing
Checklist