Small improvements to the lobby pane#4
Open
dhAlcojor wants to merge 1 commit into
Open
Conversation
dhAlcojor
commented
Aug 9, 2025
dhAlcojor
commented
- Moved the "Open file..." button to the top, next to the "New file" button
- Slightly modified the style for the recent files:
- Added a "Recent files" header
- Made the filename in bold typeface and removed the rest of the path
- Added the full path to the right of the filename in a smaller font and gray color
style: move both buttons in lobby pane to the top style: improve readability of recent file names
jpsilva
requested changes
Oct 13, 2025
| </div> | ||
| <hr v-if="recentFiles.length"> | ||
| <button type="button" v-for="file of recentFiles" :key="file" @click="openFile(file)">{{ file }}</button> | ||
| <p>Recent files</p> |
Contributor
There was a problem hiding this comment.
This should conditionally show only when there are > 0 recent files. Could wrap the whole block from the hr down the file buttons in one v-if. Also, I feel like this should be an h3, though I don't think the bold styling is necessary. I could go either way.
| <strong>{{ file.split('/').pop() }}</strong> | ||
| <span>{{file}}</span> | ||
| </button> | ||
| <hr v-if="recentFiles.length"> |
Contributor
There was a problem hiding this comment.
I don't think this hr is necessary anymore.
| <h2>Open file</h2> | ||
| <button type="button" @click="openFile()">New file</button> | ||
| <div class="file-actions"> | ||
| <button type="button" @click="openFile()">New file</button> |
Contributor
There was a problem hiding this comment.
If we're making these inline, maybe add some borders around them? They're just too flat, and that's my fault.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.