Skip to content

Small improvements to the lobby pane #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhAlcojor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Small improvements to the lobby pane #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ node_modules

# Environment files
.env

# IDEs
.idea
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,4 +136,4 @@
"webpack-node-externals": "^1.7.2",
"worker-loader": "^2.0.0"
}
}
}
12 changes: 12 additions & 0 deletions src/windows/editor-window/lobby-pane/lobby-pane.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,21 @@
h2:first-child
margin-top 0

.file-actions
display flex
justify-content start
gap 1rem

button
width fit-content

button
display block
width 100%
margin 1ex 0
border none
text-align left

span
color gray
font-size smaller
15 changes: 11 additions & 4 deletions src/windows/editor-window/lobby-pane/lobby-pane.vue.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,17 @@

<div class="lobby-content">
<h2>Open file</h2>
<button type="button" @click="openFile()">New file</button>
<div class="file-actions">
<button type="button" @click="openFile()">New file</button>

@jpsilva jpsilva Oct 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're making these inline, maybe add some borders around them? They're just too flat, and that's my fault.

<button type="button" @click="showOpenFileDialog">Open file...</button>
</div>
<hr v-if="recentFiles.length">
<button type="button" v-for="file of recentFiles" :key="file" @click="openFile(file)">{{ file }}</button>
<p>Recent files</p>

@jpsilva jpsilva Oct 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should conditionally show only when there are > 0 recent files. Could wrap the whole block from the hr down the file buttons in one v-if. Also, I feel like this should be an h3, though I don't think the bold styling is necessary. I could go either way.

<button type="button" v-for="file of recentFiles" :key="file" @click="openFile(file)">
<strong>{{ file.split('/').pop() }}</strong>
<span>{{file}}</span>
</button>
<hr v-if="recentFiles.length">

@jpsilva jpsilva Oct 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this hr is necessary anymore.

<button type="button" @click="showOpenFileDialog">Open file...</button>

</div>
</div>
</div>