Skip to content

fix: prevent zero-length clip in TrimControl (#14)#747

Open
wei123-web wants to merge 1 commit into
magic-peach:mainfrom
wei123-web:fix/trim-control-min-duration
Open

fix: prevent zero-length clip in TrimControl (#14)#747
wei123-web wants to merge 1 commit into
magic-peach:mainfrom
wei123-web:fix/trim-control-min-duration

Conversation

@wei123-web
Copy link
Copy Markdown
Contributor

@wei123-web wei123-web commented May 19, 2026

Description

Fixes a validation bug in TrimControl where trimStart could be set equal to trimEnd, producing a zero-length video passed to FFmpeg. The fix enforces a minimum gap (MIN_CLIP_DURATION = 0.1s) between the start and end values, replacing the previous >= / <= equality checks with a gap-aware comparison.

Related Issue

Closes #14

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • **GitHub username:**wei123-web
  • Contribution level: Beginner

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

@wei123-web is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

✅ PR Format Check Passed — @wei123-web

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature labels May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @wei123-web!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added the gssoc'26 GirlScript Summer of Code 2026 label May 19, 2026
@wei123-web wei123-web force-pushed the fix/trim-control-min-duration branch from 3189974 to 2ef6d50 Compare May 19, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] TrimControl allows trimStart to equal trimEnd producing zero-length video

1 participant