Skip to content

fix: prevent zero-length clip in TrimControl (#14) #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wei123-web wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

fix: prevent zero-length clip in TrimControl (#14) #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/components/TrimControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import { EditRecipe } from "@/lib/types";

const MIN_CLIP_DURATION = 0.1;

interface Props {
recipe: EditRecipe;
onChange: (patch: Partial<EditRecipe>) => void;
Expand All @@ -13,14 +15,14 @@ export default function TrimControl({ recipe, onChange, duration }: Props) {
const n = parseFloat(val);
if (isNaN(n) || n < 0) return;
if (duration > 0 && n >= duration) return;
if (recipe.trimEnd !== null && n >= recipe.trimEnd) return;
if (recipe.trimEnd !== null && n >= recipe.trimEnd - MIN_CLIP_DURATION) return;
onChange({ trimStart: n });
};

const handleEnd = (val: string) => {
if (val === "") { onChange({ trimEnd: null }); return; }
const n = parseFloat(val);
if (isNaN(n) || n <= 0 || n <= recipe.trimStart) return;
if (isNaN(n) || n <= 0 || n <= recipe.trimStart + MIN_CLIP_DURATION) return;
if (duration > 0 && n > duration) return;
onChange({ trimEnd: n });
};
Expand Down Expand Up @@ -67,6 +69,12 @@ export default function TrimControl({ recipe, onChange, duration }: Props) {
Duration: {duration.toFixed(1)}s
</p>
)}
{recipe.trimEnd !== null &&
recipe.trimEnd - recipe.trimStart < MIN_CLIP_DURATION && (
<p className="text-[10px] text-red-500 font-heading">
Clip must be at least 0.1 seconds long.
</p>
)}
</div>
);
}