Support various PHP framework constellations by makomweb · Pull Request #18 · makomweb/tactix

makomweb · 2026-02-23T12:42:14Z

extract YAML configuration for the blacklist
support various framework constellations: Symfony, Laravel, standalone, CLI, tests

Copilot

Pull request overview

This PR refactors “forbidden relations” handling into a configurable Blacklist (including Symfony bundle configuration + Flex recipes) and updates the checking/reporting APIs to support multiple runtime environments (Symfony/Laravel/standalone/tests).

Changes:

Replace hardcoded blacklist logic with Blacklist + BlacklistFactory and YAML-backed defaults.
Convert YieldViolations/Check to instance-based services that depend on an injected Blacklist.
Add Symfony bundle config wiring + Flex recipes, update tests/docs, and bump toolchain dependencies.

Reviewed changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
tests/bootstrap.php	Avoid undefined `APP_DEBUG` access in test bootstrap.
tests/Unit/TraitTest.php	New unit test to ensure traits are detected by analyzer.
tests/Unit/ReportCommandTest.php	Update `ReportCommand` tests for new `Blacklist` dependency.
tests/Unit/MissingTagTest.php	Update `Check` usage to instance-based API.
tests/Unit/InterfaceTest.php	Update `YieldViolations` usage to instance-based API.
tests/Unit/ForbiddenRelationsTest.php	Update `Check` usage to instance-based API for folder/class checks.
tests/Unit/ExceptionTest.php	Update `YieldViolations` usage to instance-based API.
tests/Data/MyTrait.php	New fixture trait for analyzer tests.
tests/Data/MyConsumesTrait.php	New fixture consuming a trait property.
symfony/recipes/makomweb/tactix/next/manifest.json	Add Flex recipe manifest for next version.
symfony/recipes/makomweb/tactix/next/config/packages/tactix.yaml	Provide default Symfony config for blacklist rules.
symfony/recipes/makomweb/tactix/0.1/manifest.json	Add Flex recipe manifest for 0.1.
symfony/recipes/makomweb/tactix/0.1/config/packages/tactix.yaml	Provide default Symfony config for blacklist rules.
src/YieldViolations.php	Inject `Blacklist` and use it to decide forbidden relations (now instance methods).
src/Forbidden.php	Remove old hardcoded blacklist implementation.
src/DependencyInjection/TactixExtension.php	Add DI parameter wiring for blacklist config.
src/DependencyInjection/Configuration.php	Define `tactix.blacklist` configuration tree with defaults.
src/Command/ReportCommand.php	Inject `Blacklist` and use it when producing forbidden-relations output.
src/Check.php	Convert to instance service depending on `YieldViolations`.
src/BlacklistFactory.php	Add helpers to build/load a `Blacklist` from YAML/defaults.
src/Blacklist.php	New blacklist model and relation-checking logic.
src/Analyzer/Relation.php	Remove `Relation::isForbidden()` (delegated to `Blacklist`).
src/Analyzer/Class/ClassNameAnalyzer.php	Treat traits as “class-like” declarations for naming analysis.
resources/config/tactix.yaml	Add default blacklist YAML shipped with the package.
resources/config/services.yaml	Register `Blacklist` service + wire `ReportCommand`.
phpunit.xml.dist	Update ini/server values and PHPUnit version constraints.
composer.lock	Dependency updates (Symfony components, PHPUnit, tooling).
composer.json	Set version, adjust PHPUnit constraint, add Symfony Flex metadata.
README.md	Document new integration patterns for Symfony/Laravel/standalone usage.
Makefile	Add maintenance targets for dependency updates.
.php-cs-fixer.dist.php	Update fixer rules (incl. phpdoc handling).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-24T08:01:19Z

@makomweb I've opened a new pull request, #19, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-02-24T08:01:58Z

@makomweb I've opened a new pull request, #20, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…README snippet Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>

Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-02-24T08:03:54Z

@makomweb I've opened a new pull request, #21, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-24T08:04:20Z

@makomweb I've opened a new pull request, #22, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>

Copilot · 2026-02-24T08:06:08Z

@makomweb I've opened a new pull request, #23, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…conversion Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>

fix: add missing `use` statements in README usage snippet

Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>

Fix missing `BlacklistFactory` import in standalone usage example

Cache Blacklist enum conversion in constructor

Fix Laravel README example: wrong method and missing import

Fix deprecated non-static call to instance method in YieldViolations

Copilot

Pull request overview

Copilot reviewed 30 out of 31 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

makomweb added 5 commits February 23, 2026 11:04

prepare blacklist configuration

0fc366f

consolidate blacklist + forbidden

1cfea07

refactor Blacklist

81640cc

fix QA

9d21f61

add factory for default blacklist

10d093d

makomweb changed the title ~~Next~~ Support various PHP framework constellations Feb 23, 2026

makomweb added 10 commits February 23, 2026 14:10

fix argument name

39fce3f

add Flex recipe

0cabb0e

feat: add Symfony Flex recipe for automatic configuration

652449a

simplify recipe

b43b7b1

add traits to the class analyzer

a9e92ac

update dependencies

15115aa

revert changes

229555f

update phpunit

caf8642

fix error when running tests

ab8bf36

fix phpunit.xml.dist

e06857c

makomweb self-assigned this Feb 24, 2026

makomweb requested a review from Copilot February 24, 2026 07:39

Copilot started reviewing on behalf of makomweb February 24, 2026 07:39 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Initial plan

dd8e5a2

Copilot AI mentioned this pull request Feb 24, 2026

fix: add missing use statements in README usage snippet #19

Merged

makomweb and others added 2 commits February 24, 2026 09:01

Update README.md

63cb464

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

7358995

Copilot AI mentioned this pull request Feb 24, 2026

Fix missing BlacklistFactory import in standalone usage example #20

Merged

makomweb and others added 3 commits February 24, 2026 09:01

Update Makefile

307a7ff

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: add missing use statements for Blacklist and YieldViolations in …

954e159

…README snippet Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>

Fix missing BlacklistFactory import in standalone usage example

02432ce

Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>

makomweb and others added 2 commits February 24, 2026 09:02

Update src/DependencyInjection/TactixExtension.php

88e9304

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

a563ef0

Copilot AI mentioned this pull request Feb 24, 2026

Cache Blacklist enum conversion in constructor #21

Merged

Initial plan

1781a10

Copilot AI mentioned this pull request Feb 24, 2026

Fix Laravel README example: wrong method and missing import #22

Merged

makomweb and others added 3 commits February 24, 2026 09:04

Update phpunit.xml.dist

65734d9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix Laravel example: use fromYamlFile and import Blacklist in README.md

df7d644

Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>

Initial plan

7bfea01

Copilot AI mentioned this pull request Feb 24, 2026

Fix deprecated non-static call to instance method in YieldViolations #23

Merged

makomweb and others added 8 commits February 24, 2026 09:06

Update src/BlacklistFactory.php

30f83ec

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Cache computed rules in Blacklist constructor to avoid repeated enum …

dfb56cc

…conversion Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>

Merge pull request #19 from makomweb/copilot/sub-pr-18

d935955

fix: add missing `use` statements in README usage snippet

Fix non-static call to instance method fromClassName in fromFolder

74a2570

Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>

Merge pull request #20 from makomweb/copilot/sub-pr-18-again

1e9d0f9

Fix missing `BlacklistFactory` import in standalone usage example

Merge pull request #21 from makomweb/copilot/sub-pr-18-another-one

fc17fc6

Cache Blacklist enum conversion in constructor

Merge pull request #22 from makomweb/copilot/sub-pr-18-yet-again

440d3c2

Fix Laravel README example: wrong method and missing import

Merge pull request #23 from makomweb/copilot/sub-pr-18-one-more-time

060c8f0

Fix deprecated non-static call to instance method in YieldViolations

makomweb requested a review from Copilot February 24, 2026 08:15

Copilot started reviewing on behalf of makomweb February 24, 2026 08:15 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Comment thread src/Blacklist.php Outdated

Comment thread README.md Outdated

Comment thread composer.json Outdated

Comment thread tests/Data/MyConsumesTrait.php

Comment thread resources/config/tactix.yaml Outdated

makomweb and others added 4 commits February 24, 2026 09:26

Update composer.json

1a37adb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update README.md

02f76af

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update resources/config/tactix.yaml

4af7126

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

improve building the rules

b0c8c0a

makomweb merged commit 22fa081 into master Feb 24, 2026
1 check passed

makomweb deleted the next branch February 24, 2026 08:48

makomweb restored the next branch February 24, 2026 08:49

Conversation

makomweb commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants