Fix Laravel README example: wrong method and missing import#22
Merged
Fix Laravel README example: wrong method and missing import#22
Conversation
Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on PHP framework constellations support
Fix Laravel README example: wrong method and missing import
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Laravel integration example in
README.mdusedBlacklistFactory::fromYaml()with a file path, but that method expects a pre-parsed array. Additionally,Blacklist::classwas referenced without being imported.Changes
BlacklistFactory::fromYaml($configPath)→fromYamlFile($configPath)—fromYaml()takesarray, not a path string;fromYamlFile()is the correct entry point for file-based loading.use Symfony\Component\Yaml\Yamlwithuse Tactix\Blacklist— the Yaml import was unused;Blacklistwas the missing one needed byBlacklist::class.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.