Skip to content

Fix Laravel README example: wrong method and missing import#22

Merged
makomweb merged 2 commits intonextfrom
copilot/sub-pr-18-yet-again
Feb 24, 2026
Merged

Fix Laravel README example: wrong method and missing import#22
makomweb merged 2 commits intonextfrom
copilot/sub-pr-18-yet-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 24, 2026

The Laravel integration example in README.md used BlacklistFactory::fromYaml() with a file path, but that method expects a pre-parsed array. Additionally, Blacklist::class was referenced without being imported.

Changes

  • BlacklistFactory::fromYaml($configPath)fromYamlFile($configPath)fromYaml() takes array, not a path string; fromYamlFile() is the correct entry point for file-based loading.
  • Replaced use Symfony\Component\Yaml\Yaml with use Tactix\Blacklist — the Yaml import was unused; Blacklist was the missing one needed by Blacklist::class.
use Tactix\Blacklist;
use Tactix\BlacklistFactory;

// ...
return file_exists($configPath)
  ? BlacklistFactory::fromYamlFile($configPath)  // was: fromYaml($configPath)
  : BlacklistFactory::DEFAULT();

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: makomweb <1567373+makomweb@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on PHP framework constellations support Fix Laravel README example: wrong method and missing import Feb 24, 2026
Copilot AI requested a review from makomweb February 24, 2026 08:06
@makomweb makomweb marked this pull request as ready for review February 24, 2026 08:13
@makomweb makomweb merged commit 440d3c2 into next Feb 24, 2026
@makomweb makomweb deleted the copilot/sub-pr-18-yet-again branch February 24, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants