Open
Conversation
Collaborator
skaravos
commented
Mar 8, 2026
skaravos
commented
- moved vendored stuff into a 'vendored' subdir
- cmake improvements
- docker build script improvements
- add basic CLAUDE.md
Notes: - Silences warning about policy CMP0174 blah blah cmake_parse_arguments setting empty string args blah blah Refs: - "https://cmake.org/cmake/help/latest/policy/CMP0174.html"
Notes: - The previous approach was doing internal buffering, causing the lines of stderr and stdout to be interleaved in a weird way. - I could also have used the `-W interactive` argument to awk, but that is unintuitive compared to the nicely named sed flag.
Notes: - Some of the vcpkg dependencies don't work in ubuntu 16 or 18 anymore
Notes: - The default for ninja is _probably_ fine, but the explicit way is probably better?
Notes: - Allows use of $<LINK_LIBRARY:WHOLE_ARCHIVE,...>
Changes: - Moved all vendored libraries into a subdirectory - Added a dedicated CMakeLists.txt for these libs - Added alias cmake targets with 'vendored::' prefix for these targets - Removed unnecessary target_include_directories from ty interface
Notes: - This tells vcpkg to compile it so we can reference the just-compiled version instead of relying on the user to already have a system-installed copy of luajit.
Owner
Sigh... another loss. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.