fix(cf): collapse newlines in send so one message stays one line#8
Merged
Conversation
…riant)
`cf send "$msg"` wrote the arg verbatim, so a message containing a newline
landed as two physical lines. The chatroom is line-oriented ("Format: Name:
msg") and `await` derives the sender via `tail -n 1 | cut -d: -f1`, so the
wrapped second line — which has no "Name:" prefix — gets parsed as a phantom
message from a sender named after the text. Collapse newlines to spaces in
both `send` and `send-await`.
Adds `test_send_collapses_newlines` (a 2-line message must add exactly one
physical line, prefixed by the sender). Fails against the old code, passes
with the fix; suite 41/41.
Second of the follow-ups noted when #1 was closed as superseded.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
cf send "$msg"(andsend-await) wrote the argument verbatim:A message containing a newline therefore lands as two physical lines. The chatroom is line-oriented (its header literally says
Format: Name: msg), andawaitderives the sender withtail -n 1 | cut -d: -f1— so the wrapped second line, which has noName:prefix, is parsed as a phantom message from a sender named after the text.Repro (before)
Fix
Collapse newlines to spaces in
sendandsend-await:Test
test_send_collapses_newlines— a 2-line message must add exactly one physical line, prefixed by the sender. It fails on the old code, passes on the fix; suite 41/41.Second of the follow-ups flagged when #1 was closed as superseded (after #7 landed the
set -eregister fix).🤖 Generated with Claude Code