Skip to content

fix(cf): collapse newlines in send so one message stays one line #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marksverdhei merged 1 commit into from
Jun 27, 2026
Merged

fix(cf): collapse newlines in send so one message stays one line #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,10 @@ case "$CMD" in
[ -z "$1" ] && { echo "Usage: cf send \"message\"" >&2; exit 1; }
load_session
[ -z "$JOINED" ] && { echo "Must join first: cf join" >&2; exit 1; }
printf '%s: %s\n' "$MYNAME" "$1" >> "$CHATFILE"
# Collapse newlines so one send stays one line — the "Name: msg" invariant
# that read/await depend on. A literal newline would otherwise land as a
# prefix-less second line that await parses as a phantom sender.
printf '%s: %s\n' "$MYNAME" "${1//$'\n'/ }" >> "$CHATFILE"
;;

await|a|wait|w)
Expand All @@ -248,7 +251,7 @@ case "$CMD" in
[ -z "$1" ] && { echo "Usage: cf send-await \"message\"" >&2; exit 1; }
load_session
[ -z "$JOINED" ] && { echo "Must join first: cf join" >&2; exit 1; }
printf '%s: %s\n' "$MYNAME" "$1" >> "$CHATFILE"
printf '%s: %s\n' "$MYNAME" "${1//$'\n'/ }" >> "$CHATFILE"
tail -f -n 0 "$CHATFILE" | head -n 1
;;

Expand Down
23 changes: 23 additions & 0 deletions test_cf.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,28 @@ test_special_characters_in_message() {
teardown
}

test_send_collapses_newlines() {
# Regression: a multi-line `send` arg must stay one physical line, or
# read/await misparse the wrapped text as a phantom sender (it has no
# "Name:" prefix). Newlines collapse to spaces.
setup
"$CF_PATH" create-room 2>/dev/null || true
local name rc=0 before after last
name=$("$CF_PATH" register Chatfile)
"$CF_PATH" join >/dev/null
before=$(wc -l < Chatfile)
"$CF_PATH" send "line one
line two"
after=$(wc -l < Chatfile)
last=$(tail -n 1 Chatfile)
if [ "$((after - before))" -ne 1 ] || [ "$last" != "$name: line one line two" ]; then
echo " multi-line send not collapsed: +$((after - before)) line(s), last='$last'" >&2
rc=1
fi
teardown
return $rc
}

test_multiline_preserved() {
setup
"$CF_PATH" create-room 2>/dev/null || true
Expand Down Expand Up @@ -685,6 +707,7 @@ echo "Edge Case Tests:"
run_test "register survives name collisions (set -e)" test_register_survives_name_collisions
run_test "username uniqueness" test_username_uniqueness
run_test "special characters in message" test_special_characters_in_message
run_test "send collapses newlines (one-line invariant)" test_send_collapses_newlines
run_test "multiline preserved" test_multiline_preserved

echo ""
Expand Down
Loading