Closed
Fix flakey TestOnRejoinBobCanSeeButNotDecryptHistoryInPublicRoom#250
Conversation
Remove the arbitrary 1-second sleep after Bob's rejoin that was giving time for key forwarding to complete (causing the undecryptable event to be decrypted before the assertion). Replace direct MustGetEvent call with the proper waiter pattern (consistent with other tests in the file) that waits for the backpaginated event to appear in the timeline before checking its decryption state.
Copilot created this pull request from a session on behalf of
pixlwave
July 20, 2026 13:32
View session
Member
|
Well clearly that didn't work… 🙃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Race between key forwarding and the UTD assertion: after Bob rejoins, the 1-second sleep gave Alice's SDK time to fulfill Bob's
m.room_key_request, soMustGetEventsometimes returned the event already decrypted.time.Sleep(time.Second)after Bob's rejoin that widened the key-forwarding race windowTestAliceInvitesBobSendAndBobCanDecrypt) to wait for the backpaginated event before asserting