Skip to content

Fix flakey TestOnRejoinBobCanSeeButNotDecryptHistoryInPublicRoom #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 1 commit into from
Closed

Fix flakey TestOnRejoinBobCanSeeButNotDecryptHistoryInPublicRoom #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/membership_acls_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,13 @@ func TestOnRejoinBobCanSeeButNotDecryptHistoryInPublicRoom(t *testing.T) {
tc.Bob.MustJoinRoom(t, roomID, []spec.ServerName{clientTypeA.HS})
waiter = bob.WaitUntilEventInRoom(t, roomID, api.CheckEventHasMembership(bob.UserID(), "join"))
waiter.Waitf(t, 5*time.Second, "bob did not see own join")
// this is required for some reason else tests fail
time.Sleep(time.Second)

// bob hits scrollback and should see but not be able to decrypt the message
// bob hits scrollback and should see but not be able to decrypt the message.
// Set up a waiter for the event before backpaginating, so we know when it's available.
waiter = bob.WaitUntilEventInRoom(t, roomID, api.CheckEventHasEventID(evID))
bob.MustBackpaginate(t, roomID, 5)
// TODO: jJ runs fail as the timeline omits the event e.g it has leave,join and not leave,msg,join.
waiter.Waitf(t, 5*time.Second, "bob did not see backpaginated message")

ev := bob.MustGetEvent(t, roomID, evID)
must.NotEqual(t, ev.Text, onlyAliceBody, "bob was able to decrypt a message from before he was joined")
must.Equal(t, ev.FailedToDecrypt, true, "message not marked as failed to decrypt")
Expand Down
Loading