Remove check on Room IDs having a domain component#467
Open
jason-famedly wants to merge 2 commits into
Open
Conversation
… be opaque strings
1 task
Author
|
Actually, you know what? This is used in a couple different places for other sigil checks. Let me re-evaluate. I was to hasty. |
To be fair, "user" is only featured once while "room" is far more prevelant
Author
There, that is more inclusive of uses other |
kegsay
reviewed
Jul 2, 2026
| if _, err = domainFromID(id); err != nil { | ||
| return | ||
| if kind != "room" { | ||
| // RoomIDs should always be an opaque string, so only do this check for other kinds of ID |
Member
There was a problem hiding this comment.
This isn't true though for rooms <v12.
It would be better to assert that the room ID either:
- has a domain OR
- is exactly 43 characters of base 64 (we do a similar check in Synapse)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as Room IDs should be opaque strings
Pull Request Checklist
Signed-off-by:
Jason Little <j.little@famedly.com>