Skip to content

Remove check on Room IDs having a domain component #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jason-famedly wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove check on Room IDs having a domain component #467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2605408
Remove check on Room IDs having a domain component as Room IDs should…
jason-famedly Jun 30, 2026
b97d4a0
Ensure this check still exists for other kinds of ID, like "user"
jason-famedly Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions event.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,11 @@ const (
)

func checkID(id, kind string, sigil byte) (err error) {
if _, err = domainFromID(id); err != nil {
return
if kind != "room" {
// RoomIDs should always be an opaque string, so only do this check for other kinds of ID

@kegsay kegsay Jul 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't true though for rooms <v12.

It would be better to assert that the room ID either:

  • has a domain OR
  • is exactly 43 characters of base 64 (we do a similar check in Synapse)

if _, err = domainFromID(id); err != nil {
return
}
}
if id[0] != sigil {
err = fmt.Errorf(
Expand Down