Redesign and track numba_types; exclude black-formatting for scripts generated by code_factory#396
Open
ilhamv wants to merge 7 commits intomcdc-project:devfrom
Open
Redesign and track numba_types; exclude black-formatting for scripts generated by code_factory#396ilhamv wants to merge 7 commits intomcdc-project:devfrom
ilhamv wants to merge 7 commits intomcdc-project:devfrom
Conversation
ilhamv
changed the title
nglaser3
approved these changes
Apr 13, 2026
Collaborator
There was a problem hiding this comment.
Thank you @ilhamv! The changes to numba_types looks good to me, and thank you for fixing the black changes to mcdc_get and mcdc_set! I have one request to add a docstring or comment to the decode_structure_item method in numba_objects_generator.py just to clarify what the indices into the item are, but otherwise approve. If you do not think the docstring / comment is needed since the method is in a part of the code that most people will never touch, that is ok with me and I will merge as is :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code_factorygeneratesmcdc_get/,mcdc_set/, andnumba_types.py. The last one is currently not git-tracked because it is problem-dependent. Unfortunately, this problem-dependent behavior and literal import hinder running multiple instances of MC/DC simulation simultaneously.This PR redesigns
numba_types.pyso that it is no longer problem-dependent.Additionally, we exclude black-formatting check for the three files generated by
code_factory.