feat(images): add marketplace-gen1 image - #18468
Open
binujp wants to merge 1 commit into
Open
Conversation
Add the AZL4 1P Marketplace Gen1 (BIOS) image, ported from the azl3.0 marketplace-gen1 image config. Package selection preserves the azl3.0 grouping (core-packages-image, core-packages-base-image, core-packages-container, marketplace-tools, azurevm, hyperv); packages missing in AZL4 are mapped to their closest AZL4 equivalent or dropped. Legacy BIOS boot is provided via a GPT hybrid (eficsm) disk, matching the azl3.0 GPT + bios_grub layout. Azure guest configuration for cloud-init, chrony/PTP, and Hyper-V udev remains injected as loose image files. There is no config.sh because post-install customization is not needed. These loose guest customizations are temporary. Follow up by creating appropriate subpackages that own the configuration files, installing those subpackages in the image, and deleting the corresponding KIWI file injections once the subpackages are available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 727c4c35-afde-4eb0-82bf-b307f6550d58
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot stopped reviewing on behalf of
binujp due to an error
August 17, 2026 15:54
reuben olinsky (reubeno)
requested changes
Aug 17, 2026
| <package name="azurelinux-repos" /> | ||
|
|
||
| <!-- Azure marketplace guest configuration --> | ||
| <!-- TODO: Move these customizations and files into subpackages, then delete these file entries. --> |
There was a problem hiding this comment.
issue(blocking): Agreed with the TODO here -- we've worked hard to keep config files out of the image definitions, so placing them in packages/sub-packages is the right call.
| @@ -0,0 +1,159 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
question(blocking): Did you look at whether we could avoid a completely separate definition and instead find a way for gen1 to be a profile / derivative of vm-base?
Dan Streetman (ddstreetmicrosoft)
requested changes
Aug 17, 2026
There was a problem hiding this comment.
issue(blocking):
in addition to reubeno's review about reusing/extending our current image definition and placing config files into packages instead of image definitions:
- I don't think we want to completely replace the cloud-init or chrony config files.
- The udev rule isn't needed, as it's already provided in current rules.
- For the systemd drop-in, that might be ok if moved into a package (though I'd like to think more about its potential impact)
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
azldev image build marketplace-gen1 --arch x86_64AB#18608