Skip to content

fuzz: exclude the SDK and CRT from code coverage reporting#23

Merged
DHowett merged 1 commit into
mainfrom
dev/duhowett/onefuzz-cleanup
Apr 6, 2026
Merged

fuzz: exclude the SDK and CRT from code coverage reporting#23
DHowett merged 1 commit into
mainfrom
dev/duhowett/onefuzz-cleanup

Conversation

@DHowett

@DHowett DHowett commented Apr 6, 2026

Copy link
Copy Markdown
Member

Right now, our coverage sits at 41%. If we exclude the code we did not author, that number should grow to 79%.

Right now, our coverage sits at 41%. If we exclude the code we did not
author, that number should grow to _79%_.
! *vctools*
! *externalapis*
! *internal_shared.h
! *type_traits

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this match against a full path? I wonder if there's something we can match against that would capture the whole STL instead.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe instead of the global wildcard above, maybe we could capture just our code?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to, but I was worried that I didn't know where the source path was rooted from onefuzz's perspective.

(Also, it puts the ExternalAPIs folder in /src (???))

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(rooted: because I wanted to put in src/lib/* rather than */src/lib/*)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whole STL instead.

Ugh, I hate this honestly. It looks like this:

image

so somewhat "not really", but also "somewhat"?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it just pulls source paths from the pdb(?), so it would be specific to the CI machine I'd think. But that's also probably not consistent/guaranteed. Anyway, not that big of a deal regardless

@DHowett DHowett merged commit 0e806ee into main Apr 6, 2026
104 checks passed
@DHowett DHowett deleted the dev/duhowett/onefuzz-cleanup branch April 6, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants