Skip to content

fuzz: exclude the SDK and CRT from code coverage reporting #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DHowett merged 1 commit into from
Apr 6, 2026
Merged

fuzz: exclude the SDK and CRT from code coverage reporting #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/fuzz/OneFuzzConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
"fuzz-inflate.pdb",
"clang_rt.asan_dynamic-x86_64.dll"
],
"SdlWorkItemId": 58760469
"SdlWorkItemId": 58760469,
"SourcesAllowListPath": "fuzzing-sources.txt"
},
{
"jobNotificationEmail": "condev@microsoft.com",
Expand Down Expand Up @@ -55,7 +56,8 @@
"fuzz-inflate64.pdb",
"clang_rt.asan_dynamic-x86_64.dll"
],
"SdlWorkItemId": 58760469
"SdlWorkItemId": 58760469,
"SourcesAllowListPath": "fuzzing-sources.txt"
}
]
}
}
10 changes: 10 additions & 0 deletions test/fuzz/fuzzing-sources.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# When using a source-allow-list (which this is), you have to specify * for everything to be included
*

# Now, exclude via wildcarded paths all of the following locations.
# This is because code-coverage data on our fuzzers shouldn't be covering
# how well we exercise the CRT, STL, etc.
! *vctools*
! *externalapis*
! *internal_shared.h
! *type_traits

@dunhor dunhor Apr 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this match against a full path? I wonder if there's something we can match against that would capture the whole STL instead.

@dunhor dunhor Apr 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe instead of the global wildcard above, maybe we could capture just our code?

@DHowett DHowett Apr 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to, but I was worried that I didn't know where the source path was rooted from onefuzz's perspective.

(Also, it puts the ExternalAPIs folder in /src (???))

@DHowett DHowett Apr 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(rooted: because I wanted to put in src/lib/* rather than */src/lib/*)

@DHowett DHowett Apr 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whole STL instead.

Ugh, I hate this honestly. It looks like this:

image

so somewhat "not really", but also "somewhat"?

@dunhor dunhor Apr 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it just pulls source paths from the pdb(?), so it would be specific to the CI machine I'd think. But that's also probably not consistent/guaranteed. Anyway, not that big of a deal regardless

Loading