[rush] fix: wire ProblemCollector correctly into the terminal pipeline#5707
Merged
Merged
Conversation
…ansform, make line/column optional in patterns, always wire problemCollector Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/d3363f24-2939-4850-85fb-b8b3eafa7a1e
… handle paths with spaces Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/d3363f24-2939-4850-85fb-b8b3eafa7a1e
Copilot created this pull request from a session on behalf of
dmichon-msft
March 20, 2026 21:34
View session
…ge; revert optional regex groups Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/191532d8-1356-4937-9fe4-bddc8b3fdcaf
…FormattedErrorMessage Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/e0b803db-46de-4bf5-a531-31105741fbf8
…json to make column optional Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/8b2eb275-c191-44e9-8d69-dd1c166c7985
dmichon-msft
requested changes
Mar 20, 2026
dmichon-msft
left a comment
Contributor
There was a problem hiding this comment.
Let's scope this PR down to just the changes to OperationExecutionRecord. Be sure to add a change file for @microsoft/rush of type path describing the change.
…ges; add @microsoft/rush patch change file Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/1bcedf3e-f266-4978-ad80-c7ccb325056a
Contributor
Author
Done in 3cfd6ed. Reverted |
dmichon-msft
approved these changes
Mar 20, 2026
iclanton
reviewed
Mar 20, 2026
iclanton
approved these changes
Mar 20, 2026
bmiddha
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProblemCollectorinOperationExecutionRecordhad three issues: it was missingpreventAutoclose: true, it received raw ANSI-colored output (causing regex mismatches), and it was silently dropped from the pipeline when no log file was being written.Changes
OperationExecutionRecord.tspreventAutoclose: truetoProblemCollectorconstruction, consistent withStdioSummarizerTextRewriterTransform { removeColors: true }stage between the splitter andproblemCollectorto strip VT/ANSI escape codes before pattern matchingproblemCollectoris now always connected via an unconditionalSplitterTransform, even whenprojectLogWritableis absentUpdated pipeline topology:
⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.