Skip to content

[rush] fix: wire ProblemCollector correctly into the terminal pipeline#5707

Merged
dmichon-msft merged 6 commits into
mainfrom
copilot/update-problem-matcher-configuration
Mar 20, 2026
Merged

[rush] fix: wire ProblemCollector correctly into the terminal pipeline#5707
dmichon-msft merged 6 commits into
mainfrom
copilot/update-problem-matcher-configuration

Conversation

Copilot AI commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

ProblemCollector in OperationExecutionRecord had three issues: it was missing preventAutoclose: true, it received raw ANSI-colored output (causing regex mismatches), and it was silently dropped from the pipeline when no log file was being written.

Changes

OperationExecutionRecord.ts

  • Add preventAutoclose: true to ProblemCollector construction, consistent with StdioSummarizer
  • Inject a TextRewriterTransform { removeColors: true } stage between the splitter and problemCollector to strip VT/ANSI escape codes before pattern matching
  • Fix oversight: problemCollector is now always connected via an unconditional SplitterTransform, even when projectLogWritable is absent

Updated pipeline topology:

normalizeNewlineTransform --1--> stderrLineTransform --2--> projectLogWritable?
                                                       |
                                                       +--> stdioSummarizer
                                                       |
                                                       +--> removeColorsTransform --> problemCollector

⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

Copilot AI and others added 2 commits March 20, 2026 21:28
…ansform, make line/column optional in patterns, always wire problemCollector

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/d3363f24-2939-4850-85fb-b8b3eafa7a1e
… handle paths with spaces

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/d3363f24-2939-4850-85fb-b8b3eafa7a1e
Comment thread libraries/node-core-library/src/FileError.ts Outdated
…ge; revert optional regex groups

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/191532d8-1356-4937-9fe4-bddc8b3fdcaf
…FormattedErrorMessage

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/e0b803db-46de-4bf5-a531-31105741fbf8
Comment thread libraries/node-core-library/src/FileError.ts Outdated
…json to make column optional

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/8b2eb275-c191-44e9-8d69-dd1c166c7985

@dmichon-msft dmichon-msft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's scope this PR down to just the changes to OperationExecutionRecord. Be sure to add a change file for @microsoft/rush of type path describing the change.

…ges; add @microsoft/rush patch change file

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/1bcedf3e-f266-4978-ad80-c7ccb325056a

Copilot AI commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

Let's scope this PR down to just the changes to OperationExecutionRecord. Be sure to add a change file for @microsoft/rush of type path describing the change.

Done in 3cfd6ed. Reverted FileError.ts, FileError.test.ts, and rush-vscode-extension/package.json — the PR now only contains changes to OperationExecutionRecord.ts. Added a patch change file at common/changes/@microsoft/rush/fix-problem-collector-pipeline_2026-03-20-22-38.json.

@dmichon-msft dmichon-msft marked this pull request as ready for review March 20, 2026 22:58
@iclanton iclanton changed the title fix: wire ProblemCollector correctly into the terminal pipeline [rush] fix: wire ProblemCollector correctly into the terminal pipeline Mar 20, 2026
@dmichon-msft dmichon-msft enabled auto-merge (squash) March 20, 2026 23:13
@dmichon-msft dmichon-msft disabled auto-merge March 20, 2026 23:13
@dmichon-msft dmichon-msft enabled auto-merge (squash) March 20, 2026 23:14
@dmichon-msft dmichon-msft merged commit 1a4e287 into main Mar 20, 2026
9 checks passed
@dmichon-msft dmichon-msft deleted the copilot/update-problem-matcher-configuration branch March 20, 2026 23:20
@github-project-automation github-project-automation Bot moved this from Needs triage to Closed in Bug Triage Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

4 participants