Skip to content

[rush] fix: wire ProblemCollector correctly into the terminal pipeline #5707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmichon-msft merged 6 commits into from
Mar 20, 2026
Merged

[rush] fix: wire ProblemCollector correctly into the terminal pipeline #5707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b166995
fix: add preventAutoclose to ProblemCollector, inject strip-colors tr…
Copilot Mar 20, 2026
99ad675
fix: use non-greedy matching in FileError problem matcher patterns to…
Copilot Mar 20, 2026
3fe471a
fix: default line and column to 1 in FileError.getFormattedErrorMessa…
Copilot Mar 20, 2026
2e8acaa
fix: line mandatory (defaults to 1), column optional in FileError.get…
Copilot Mar 20, 2026
2de5738
fix: update problem matcher regexes in rush-vscode-extension package.…
Copilot Mar 20, 2026
3cfd6ed
fix: scope PR to OperationExecutionRecord only; revert FileError chan…
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/fix-problem-collector-pipeline_2026-03-20-22-38.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Fix ProblemCollector wiring in OperationExecutionRecord: add preventAutoclose, strip ANSI colors before matching, and always include problemCollector in the terminal pipeline",
"type": "patch"
Comment thread
dmichon-msft marked this conversation as resolved.
}
],
"packageName": "@microsoft/rush"
}
21 changes: 15 additions & 6 deletions libraries/rush-lib/src/logic/operations/OperationExecutionRecord.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ export class OperationExecutionRecord implements IOperationRunnerContext, IOpera
preventAutoclose: true
});
public readonly problemCollector: ProblemCollector = new ProblemCollector({
// Allow writing to this object after transforms have been closed. We clean it up manually in a finally block.
preventAutoclose: true,
matcherJson: [
{
name: 'rushstack-file-error-unix',
Expand Down Expand Up @@ -322,14 +324,21 @@ export class OperationExecutionRecord implements IOperationRunnerContext, IOpera
//
// +--> quietModeTransform? --> collatedWriter
// |
// normalizeNewlineTransform --1--> stderrLineTransform --2--> projectLogWritable
// normalizeNewlineTransform --1--> stderrLineTransform --2--> projectLogWritable?
// |
// +--> stdioSummarizer
const destination: TerminalWritable = projectLogWritable
? new SplitterTransform({
destinations: [projectLogWritable, stdioSummarizer, problemCollector]
})
: stdioSummarizer;
// |
// +--> removeColorsTransform --> problemCollector
const removeColorsTransform: TextRewriterTransform = new TextRewriterTransform({
destination: problemCollector,
removeColors: true
});

const destination: TerminalWritable = new SplitterTransform({
destinations: projectLogWritable
? [projectLogWritable, stdioSummarizer, removeColorsTransform]
: [stdioSummarizer, removeColorsTransform]
});

const stderrLineTransform: StderrLineTransform = new StderrLineTransform({
destination,
Expand Down
Loading