[Bugfix] add missing urdf, migrate to noetic, fix python setup, colcon compatible

[AustinDeric]

What this PR does

fixes: #16

Also fixes:

$ colcon build
Starting >>> spot_ros_msgs
Starting >>> spot_urdf
Finished <<< spot_urdf [0.34s]                                                                           
Finished <<< spot_ros_msgs [0.57s]                               
Starting >>> spot_ros_interface
Starting >>> spot_ros_srvs
Finished <<< spot_ros_srvs [0.49s]                                                                             
--- stderr: spot_ros_interface                                        
error: package directory 'spot_ros_interface' does not exist
CMake Error at catkin_generated/safe_execute_install.cmake:4 (message):
  
  execute_process(/home/.../spot/spot_ws/build/spot_ros_interface/catkin_generated/python_distutils_install.sh)
  returned error code
Call Stack (most recent call first):
  cmake_install.cmake:56 (include)


---
Failed   <<< spot_ros_interface [1.56s, exited with code 1]

Summary: 3 packages finished [2.24s]
  1 package failed: spot_ros_interface
  1 package had stderr output: spot_ros_interface

Testing

tested and working:

$ colcon build
Starting >>> spot_ros_msgs
Starting >>> spot_urdf
Finished <<< spot_ros_msgs [0.58s]                                                                    
Starting >>> spot_ros_interface
Starting >>> spot_ros_srvs
Finished <<< spot_ros_interface [0.39s]                                                                                       
Finished <<< spot_urdf [1.02s]                                                                          
Finished <<< spot_ros_srvs [0.51s]

Summary: 4 packages finished [1.21s]
$ source install/setup.bash
$ roslaunch spot_urdf rviz_display.launch 
... logging to /home//.ros/log/3bef68b2-0068-11eb-95ae-25be9ac3c39d/roslaunch-.log
Checking log directory for disk usage. This may take a while.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.

started roslaunch server http://........:34115/

SUMMARY
========

PARAMETERS
 * /joint_state_publisher/source_list: ['joint_state_fro...
 * /robot_description: <?xml version="1....
 * /rosdistro: noetic
 * /rosversion: 1.15.8

NODES
  /
    joint_state_publisher (joint_state_publisher/joint_state_publisher)
    robot_state_publisher (robot_state_publisher/robot_state_publisher)
    rviz (rviz/rviz)

auto-starting new master
process[master]: started with pid [82205]
ROS_MASTER_URI=http://localhost:11311

setting /run_id to 3bef68b2-0068-11eb-95ae-25be9ac3c39d
process[rosout-1]: started with pid [82215]
started core service [/rosout]
process[joint_state_publisher-2]: started with pid [82218]
process[robot_state_publisher-3]: started with pid [82223]
process[rviz-4]: started with pid [82224]

Developer Notes

• Create a noetic-branch
• remove the install_script folder
  • assume ros, pip3, python3 and colcon are installed (you can explicitly state this in readme)
  • use rosdep to install dependencies
• migrate to colcon from catkin

[ghost]

All CLA requirements met.

[AustinDeric]

standard noetic cmake minimum version: http://wiki.ros.org/noetic/Migration

[AustinDeric]

spot_ros_interface uses a script-framework, therefore the scripts were added to the path. setup.py was deleted because its used to install python modules and there are no python modules in this package:

http://docs.ros.org/noetic/api/catkin/html/howto/format2/installing_python.html