[dbus-cxx] add new port#47617
Conversation
Co-authored-by: Kai Pastor <dg0yt@darc.de>
Co-authored-by: Kai Pastor <dg0yt@darc.de>
|
Hm, now I see Qt6 changes... If you want to add a new port, I would strongly recommend to start with minimal changes to upstream. We should review the porting effort here, not innovations which belong to upstream. |
Should we just use Qt6Core instead of Qt5Core since you have mentioned that Qt5 is EOL, besides that probably should require probably just one line change, rather testing upstream new code. Using Qt6Core instead of Qt5Core is not much innovative. dbus-cxx/dbus-cxx#191 Does merged PR in upstream would increase chance that PR would be merged? |
|
Just reminder that dbus-cxx/dbus-cxx#191 is merged and PR is ready to review. |
| "default-features": [ | ||
| "glib", | ||
| "libuv", | ||
| "qt6" | ||
| ], |
There was a problem hiding this comment.
@JavierMatosD Why is this set of default-features acceptable here and rejected in other proposal? An application wouldn't use three different dispatchers at the same time.
"use Qt, GLib, or libuv as your main event loop without requiring a new thread"
https://dbus-cxx.github.io/ > Features
And all three options are off by default upstream.
https://github.com/dbus-cxx/dbus-cxx/blob/master/CMakeLists.txt#L46-L57
There was a problem hiding this comment.
They are not acceptable. This was an oversight on my part and should not have been merged in its current form.
There was a problem hiding this comment.
Reverting this PR @luadebug, please reopen this PR and note we generally try to avoid using "default-features" as it was intended to only provide the minimum required for the port to be usable but default features can be difficult to disable downstream. I recommend taking a look at our docs on default features: https://learn.microsoft.com/en-us/vcpkg/concepts/default-features#role-of-default-features and its constraints https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#default-features-should-enable-behaviors-not-apis
This reverts commit 4b55d8c.
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.aui-framework/aui#635
dbus-cxx/dbus-cxx#191