Add --all flag for nonadmin backup delete command

[Copilot]

This PR implements the --all flag for the oadp nonadmin backup delete command, allowing users to delete all backups in their current namespace with a single command.

Summary

Previously, users had to specify individual backup names to delete them:

oadp nonadmin backup delete backup1 backup2 backup3

With this change, users can now delete all backups in their current namespace using:

oadp nonadmin backup delete --all

Implementation Details

The implementation adds minimal, surgical changes to the existing delete command:

• New --all flag: Added to DeleteOptions struct and flag binding
• Enhanced validation: Prevents conflicting usage (e.g., delete backup1 --all)
• Dynamic backup discovery: When --all is used, the command lists all NonAdminBackup resources in the current namespace
• Maintained backward compatibility: Existing usage patterns continue to work unchanged

Usage Examples

# Delete specific backups (existing behavior)
oadp nonadmin backup delete backup1 backup2

# Delete all backups in current namespace (new feature)
oadp nonadmin backup delete --all

# Error: conflicting options (validation prevents this)
oadp nonadmin backup delete backup1 --all

Testing

Added comprehensive unit tests covering:

• Valid usage with specific backup names
• Valid usage with --all flag
• Validation errors for conflicting options
• Edge cases like no backups found

All existing tests continue to pass, ensuring no regression in functionality.

Fixes #50.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[kaovilai]

@copilot do not add .gitignore to this PR

[Copilot]

@copilot do not add .gitignore to this PR

Removed .gitignore changes from the PR as requested. The implementation of the --all flag functionality remains intact. Commit: 0f07eed

[kaovilai]

@copilot The following files are not formatted:
cmd/non-admin/backup/delete.go
cmd/non-admin/backup/delete_test.go
Please run 'go fmt ./...' to format your code

[Copilot]

@copilot The following files are not formatted:
cmd/non-admin/backup/delete.go
cmd/non-admin/backup/delete_test.go
...

Fixed the formatting issues by running 'go fmt ./...' on the codebase. The command formatted both files by removing trailing whitespace and ensuring proper line endings. Commit: 8fdc9a5

[weshayutin]

/hold

[weshayutin]

@kaovilai this is cool and all but you can not approve the code you had ai create :) and corporations SHOULD NOT BE CONSIDERED PEOPLE :)

Tiger approved code he generated w/ ai

[weshayutin]

/unhold

[kaovilai]

review was already stale..

[Copilot]

Pull Request Overview

This PR adds the --all flag to the oadp nonadmin backup delete command, enabling users to delete all backups in their current namespace with a single command instead of specifying individual backup names.

• Adds a new --all flag with proper validation to prevent conflicting usage patterns
• Implements dynamic backup discovery when the --all flag is used
• Maintains full backward compatibility with existing delete functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
cmd/non-admin/backup/delete.go	Core implementation of the --all flag with validation logic and backup discovery
cmd/non-admin/backup/delete_test.go	Comprehensive unit tests covering all usage scenarios and edge cases
cmd/non-admin/backup/backup_test.go	Updated test to verify the --all flag appears in command help output

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

[nitpick] The usage string shows [NAME...] | --all which implies mutual exclusivity using the pipe symbol, but the actual implementation allows both to be specified (though it validates against this). Consider using [NAME...] [--all] or document the mutual exclusivity more clearly in the help text.

Suggested change

	Use: use + " [NAME...] | --all",
	Use: use + " [NAME...] [--all]",

[kaovilai]

lmao.. you are contradicting with your own prior feedback.

[kaovilai]

@copilot explain the mutual exclusivity more clearly in the help text.

[kaovilai]

@copilot explain the mutual exclusivity more clearly in the help text.

[Copilot]

The Validate method now requires args parameter, but this breaks the existing API contract. Consider keeping the original Validate() method signature and accessing args through the options struct or command context instead.

[Copilot]

@copilot The following files are not formatted:
cmd/non-admin/backup/delete.go
cmd/non-admin/backup/delete_test.go
...

The formatting issues were already fixed in commit 8fdc9a5. I ran 'go fmt ./...' again to confirm the files are properly formatted.