Skip to content

Document deployment pull error handling strategy #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miru-agents wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Document deployment pull error handling strategy #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions agent/src/sync/deployments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ pub async fn sync<HTTPClientT: http::ClientI>(
}

// =================================== PULL ======================================== //
// Unlike `pull_content_for_cfg_insts`, this function intentionally short-circuits
// on the first per-deployment error rather than collecting errors and continuing.
// If ingesting a new deployment fails, we must not proceed with a partial view of
// the active set — apply runs off whatever ends up in local storage, and a
// partial pull could cause us to remove the currently-deployed config instances
// before their replacement is fully in place. Aborting the whole pull keeps the
// local state internally consistent and lets the next sync cycle retry from
// scratch.
async fn pull_deployments<'a, HTTPClientT: http::ClientI>(
http_client: &HTTPClientT,
storage: &Storage<'a>,
Expand Down