Drop copyfiles, bump swagger-jsdoc's glob — silence install warnings - #66
Merged
Conversation
`npm ci` printed three npm deprecation warnings on every install and in every CI run, none of which indicated a real problem: inflight@1.0.6 <- copyfiles -> glob@7 glob@7.2.3 <- copyfiles glob@11.1.0 <- swagger-jsdoc Warnings that always appear and never matter train you to ignore install output, so a genuine one gets scrolled past. copyfiles is unmaintained and was doing a job Node does natively: the build now runs scripts/copy-yaml.mjs, a dependency-free fs.cpSync with a *.yaml filter, replacing `copyfiles -u 1 "src/**/*.yaml" dist`. That removes the last two warnings' source along with the devDependency, and lets the nested copyfiles -> minimatch -> brace-expansion override go. swagger-jsdoc pins glob@11; an override moves it to ^13.0.6. glob v13 still exports the `.sync` that swagger-jsdoc calls, and the `apis` entries are literal file paths rather than patterns, so v9+ ordering changes cannot apply here. Verified: dist/*.yaml layout unchanged, the generated swagger spec is byte-identical (sha1 a5feae69 before and after), suite passes 11/11, and a cold `npm ci` now emits zero deprecation warnings with 0 audit findings. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Owner
Author
|
Docker build verified locally (daemon was down when this PR was opened):
|
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm ciprinted three npm deprecation warnings on every install and in every CI run, none indicating a real problem:Warnings that always appear and never matter train you to ignore install output, so a genuine one gets scrolled past.
Changes
copyfilesremoved. It's unmaintained and was doing a job Node does natively.scripts/copy-yaml.mjsis a dependency-freefs.cpSyncwith a*.yamlfilter, replacingcopyfiles -u 1 "src/**/*.yaml" dist. This kills two of the three warnings, drops a devDependency, and lets the nestedcopyfiles → minimatch → brace-expansionoverride go with it.swagger-jsdoc's glob overridden to^13.0.6. Safe here for two specific reasons: glob v13 still exports the.syncthat swagger-jsdoc calls, and theapisentries are literal file paths rather than patterns, so v9+ result-ordering changes cannot apply.Verification
npm cideprecation warningsa5feae69before and afterdist/*.yamllayoutnpm auditnpm ci && build && testThe spec comparison is the important one for the glob override — it's captured from the running server's
/api-docs, so it exercises swagger-jsdoc's actual glob call path.One gap
The Docker build is unverified — the daemon wasn't running locally.
scripts/is picked up by the Dockerfile'sCOPY . .and isn't in.dockerignore, and the fresh-clone build proves the script is committed and works, but note that PR CI doesn't build the image — only the tag-triggered publish workflows do. Worth a localdocker buildbefore the next release tag.🤖 Generated with Claude Code