Set warmup salt to true as default#365
Conversation
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request changes the default value of the warmup salt configuration from False to True across the schema, configuration templates, and unit tests. Feedback suggests adding a negative CLI flag (--no-warmup-salt) to ensure users can still disable warmup salting from the command line now that it is enabled by default.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| help="Prepend a unique random hex salt to each warmup prompt", | ||
| ), | ||
| ] = Field( | ||
| False, description="Prepend a unique random hex salt to each warmup prompt" | ||
| True, description="Prepend a unique random hex salt to each warmup prompt" |
There was a problem hiding this comment.
Since salt now defaults to True, users who want to disable warmup salting via the CLI will need a negative flag (e.g., --no-warmup-salt). Currently, cyclopts.Parameter only defines the alias --warmup-salt without a corresponding negative flag. Adding negative="--no-warmup-salt" ensures that users can easily disable it from the command line.
help="Prepend a unique random hex salt to each warmup prompt",
negative="--no-warmup-salt",
),
] = Field(
True, description="Prepend a unique random hex salt to each warmup prompt"
2 participants
What does this PR do?
Enable warmup to use salt by default.
Type of change
Related issues
Testing
Checklist