Fix for load_dataset function to restore ability to use custom loader

[gusario]

With update 4.0.0 function load_dataset function creates base DataLoader and don't respect loader field of DatasetMeta. In 3.x.x version it was honored via load_function, so this small change restore ability to use custom load of dataset

DatasetMeta creates base DatasetLoader in post_init if None were given, so with this change, behavior for registered datasets will remain the same

PR type

• Bug Fix
• New Feature
• Document Updates
• More Models or Datasets Support

PR information

Write the detail information belongs to this PR.

Experiment results

Paste your experiment result here(if needed).

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the load_dataset function, ensuring that custom dataset loaders defined within DatasetMeta are properly utilized. This change restores the intended flexibility for users to specify their own data loading mechanisms, aligning the behavior with previous versions and preventing the default DataLoader from being used when a custom one is intended.

Highlights

• Custom Loader Restoration: The load_dataset function has been updated to correctly honor the loader field specified in DatasetMeta, re-enabling the use of custom dataset loaders which was regressed in version 4.0.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• swift/dataset/loader.py
  • Removed the early, unconditional instantiation of DatasetLoader within the load_dataset function.
  • Relocated the loader instantiation to occur after dataset_meta is resolved, allowing it to dynamically use dataset_meta.loader.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the bug where the load_dataset function in version 4.0.0 did not respect the custom loader field specified in DatasetMeta. By moving the loader instantiation inside the dataset processing loop and using dataset_meta.loader, the change correctly restores the ability to use custom dataset loaders. The implementation is straightforward and aligns with the described intent of the pull request.