Skip to content

Fix for load_dataset function to restore ability to use custom loader #8184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jintao-Huang merged 1 commit into from
Mar 5, 2026
Merged

Fix for load_dataset function to restore ability to use custom loader #8184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions swift/dataset/loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,16 +297,6 @@ def load_dataset(
num_proc = None
train_datasets = []
val_datasets = []
loader = DatasetLoader(
num_proc=num_proc,
load_from_cache_file=load_from_cache_file,
streaming=streaming,
hub_token=hub_token,
strict=strict,
download_mode=download_mode,
columns=columns, # columns_mapping
remove_unused_columns=remove_unused_columns,
)

use_hf_default = use_hf
if use_hf_default is None:
Expand All @@ -324,6 +314,16 @@ def load_dataset(
dataset_syntax.dataset = dataset_meta.hf_dataset_id if use_hf else dataset_meta.ms_dataset_id
else:
dataset_meta = dataset_syntax.get_dataset_meta(use_hf)
loader = dataset_meta.loader(
num_proc=num_proc,
load_from_cache_file=load_from_cache_file,
streaming=streaming,
hub_token=hub_token,
strict=strict,
download_mode=download_mode,
columns=columns, # columns_mapping
remove_unused_columns=remove_unused_columns,
)
train_dataset = loader.load(dataset_syntax, dataset_meta, use_hf=use_hf)
train_dataset, val_dataset = loader.post_process(
train_dataset,
Expand Down
Loading