Skip to content

fix: wait for drop index modal to show up in e2e tests COMPASS-10525 #7910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mabaasit merged 3 commits into from
Mar 30, 2026
Merged

fix: wait for drop index modal to show up in e2e tests COMPASS-10525 #7910

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e130a2
wait for drop index modal
mabaasit Mar 25, 2026
3b94e46
Merge branch 'main' into unflake-drop-index-modal-not-showing
mabaasit Mar 25, 2026
95a0ccf
Merge branch 'main' into unflake-drop-index-modal-not-showing
mabaasit Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/compass-e2e-tests/helpers/commands/drop-index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,14 @@ export async function dropIndex(
const indexComponent = browser.$(indexComponentSelector);
await indexComponent.waitForDisplayed();

await browser.hover(indexComponentSelector);
await browser.clickVisible(
`${indexComponentSelector} ${Selectors.IndexesTableDropIndexButton}`
);
await browser.waitUntil(async () => {
await browser.hover(indexComponentSelector);
await browser.clickVisible(
`${indexComponentSelector} ${Selectors.IndexesTableDropIndexButton}`
);
// Check if modal opened successfully
return await browser.isModalOpen(Selectors.DropIndexModal);
});
Comment on lines +13 to +20
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browser.waitUntil here relies on the global default timeout and will likely produce a generic timeout error if the modal never opens, which can make CI debugging harder. Consider passing an explicit timeout (aligned with other UI waits in this repo) and a helpful timeoutMsg describing that we couldn't open the Drop Index modal after clicking the drop button.

Suggested change
await browser.waitUntil(async () => {
await browser.hover(indexComponentSelector);
await browser.clickVisible(
`${indexComponentSelector} ${Selectors.IndexesTableDropIndexButton}`
);
// Check if modal opened successfully
return await browser.isModalOpen(Selectors.DropIndexModal);
});
await browser.waitUntil(
async () => {
await browser.hover(indexComponentSelector);
await browser.clickVisible(
`${indexComponentSelector} ${Selectors.IndexesTableDropIndexButton}`
);
// Check if modal opened successfully
return await browser.isModalOpen(Selectors.DropIndexModal);
},
{
timeout: 10000,
timeoutMsg: `Timed out waiting for Drop Index modal to open after clicking drop button for index "${indexName}".`,
}
);

Copilot uses AI. Check for mistakes.
Comment on lines +13 to +20
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this waitUntil block, the click is executed before checking whether the Drop Index modal is already open. If the modal opens between retries, the next iteration can still try to click the (now covered) drop button, which can reintroduce flakiness via click interception. Consider checking isModalOpen(Selectors.DropIndexModal) first and returning true before attempting hover/click on subsequent retries.

Copilot uses AI. Check for mistakes.

await browser.waitForOpenModal(Selectors.DropIndexModal);

Expand Down
Loading