Support zoom in the KDE chart#862
Draft
julienw wants to merge 1 commit intomozilla:mainfrom
Draft
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Only the zooming part is still not merged, this is the first commit of this patch. But this needs some more work, especially we need a button to reset the zoom. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 113 113
Lines 3262 3263 +1
Branches 739 739
=======================================
+ Hits 3142 3143 +1
Misses 118 118
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a zoom on the chart by using the library
chartjs-plugin-zoom.IMO the current UX of the PR isn't great, it could be good to switch to another library such as apache echarts that supports this natively. I invested a lot of time to make the tooltips work well, hopefully echarts will make this easier too.
Deploy preview