Skip to content

Support zoom in the KDE chart #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
julienw wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Support zoom in the KDE chart #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"assert": "^2.1.0",
"buffer": "^6.0.3",
"chart.js": "^4.5.1",
"chartjs-plugin-zoom": "^2.2.0",
"crypto-browserify": "^3.12.1",
"dayjs": "^1.11.20",
"express": "^5.2.1",
Expand Down
67 changes: 47 additions & 20 deletions src/components/CompareResults/CommonGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ import {
type TooltipModel,
} from 'chart.js';
import 'chart.js/auto';
import ZoomPlugin from 'chartjs-plugin-zoom';
import * as kde from 'fast-kde';
import { Line } from 'react-chartjs-2';

import { Colors } from '../../styles/Colors';

ChartJS.register(LinearScale, LineElement);
ChartJS.register(LinearScale, LineElement, ZoomPlugin);

// This computes the min, max and the KDE bandwidth from a list of numbers.
function computeStatisticsForRuns(data: number[]) {
Expand Down Expand Up @@ -88,9 +89,29 @@ function CommonGraph({ baseValues, newValues, unit }: CommonGraphProps) {
const min = computeMin(statsForBase?.min, statsForNew?.min) * 0.95;
const max = computeMax(statsForBase?.max, statsForNew?.max) * 1.05;

//////////////////// START FAST KDE ////////////////////////
// So that the 2 KDE graphs are visually comparable, it's important to use the
// same bandwidth for both.
const bandwidth = computeMin(statsForBase?.bandwidth, statsForNew?.bandwidth);

const baseRunsDensity = Array.from(
kde.density1d(baseValues, {
bandwidth,
extent: [min, max],
}),
);
const newRunsDensity = Array.from(
kde.density1d(newValues, {
bandwidth,
extent: [min, max],
}),
);
//////////////////// END FAST KDE ////////////////////////

// The KDE line chart and categorical bubble chart share an x-axis but use
// entirely different y-scales, making the composition flexible but
// non-trivial.

const options = {
// Make the chart responsive to container size
responsive: true,
Expand Down Expand Up @@ -186,6 +207,31 @@ function CommonGraph({ baseValues, newValues, unit }: CommonGraphProps) {
padding: 10,
boxPadding: 4,
},
zoom: {
zoom: {
mode: 'x',
drag: {
enabled: true,
borderWidth: 1,
backgroundColor: 'rgba(225,225,225,0.5)',
},
wheel: {
enabled: true,
speed: 0.2,
},
pinch: {
enabled: true,
},
},
pan: {
enabled: true,
mode: 'x',
modifierKey: 'ctrl',
},
limits: {
x: { min: 'original', max: 'original', minRange: bandwidth },
},
},
},
scales: {
x: {
Expand Down Expand Up @@ -276,25 +322,6 @@ function CommonGraph({ baseValues, newValues, unit }: CommonGraphProps) {

const allValuesData = [...baseValuesData, ...newValuesData];

//////////////////// START FAST KDE ////////////////////////
// So that the 2 KDE graphs are visually comparable, it's important to use the
// same bandwidth for both.
const bandwidth = computeMin(statsForBase?.bandwidth, statsForNew?.bandwidth);

const baseRunsDensity = Array.from(
kde.density1d(baseValues, {
bandwidth,
extent: [min, max],
}),
);
const newRunsDensity = Array.from(
kde.density1d(newValues, {
bandwidth,
extent: [min, max],
}),
);
//////////////////// END FAST KDE ////////////////////////

const data = {
datasets: [
{
Expand Down