feat: add custom event logging for selectPlacements#43
Merged
nickolas-dimitrakas merged 4 commits intomainfrom Jan 29, 2026
Merged
Conversation
nickolas-dimitrakas
requested review from
BrandonStalnaker,
denischilik,
jamesnrokt and
thomson-t
nickolas-dimitrakas
force-pushed
the
feat/add-custome-event-logging-for-selectPlacements
branch
from
9b9b5d5 to
ed85e67
Compare
jamesnrokt
approved these changes
Jan 23, 2026
Co-authored-by: James Newman <james.newman@rokt.com>
4 tasks
addresses @rmi22186 comments
rmi22186
approved these changes
Jan 29, 2026
BrandonStalnaker
approved these changes
Jan 29, 2026
nickolas-dimitrakas
deleted the
feat/add-custome-event-logging-for-selectPlacements
branch
nickolas-dimitrakas
restored the
feat/add-custome-event-logging-for-selectPlacements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectPlacements/executeWithIdentifieris called, capturing the prepared attributes for analyticslogSelectPlacementEvent:inMPKitRoktand calls it from both the UIKit path (executeWithIdentifier:) and SwiftUI path (MPRoktLayout)simulator-actionto install iOS Simulator runtimeAdditional Notes
logSelectPlacementEvent:is exposed in the public header because the Swift module (mParticle-Rokt-Swift) needs to call it fromMPRoktLayout.Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)