Skip to content

fix: align IssueBuilder API with SKILL.md documentation #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpaulosky merged 3 commits into from
Feb 21, 2026
Merged

fix: align IssueBuilder API with SKILL.md documentation #26

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9a84fc
Initial plan
Copilot Feb 20, 2026
5d24d65
fix: add AsClosed() builder method and align SKILL.md examples with a…
Copilot Feb 20, 2026
b1bdf87
Merge branch 'feature/dto-refactor-and-soft-delete' into copilot/sub-…
mpaulosky Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .squad/skills/xunit-test-builders/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ var issue = IssueBuilder.Default().Build();
var issue = IssueBuilder.Default()
.WithTitle("Custom Title")
.WithDescription("Custom Description")
.AsArchived()
.AsClosed()
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example calls AsClosed(), but tests/Unit/Builders/IssueBuilder.cs currently only exposes AsArchived()/AsActive() and has no AsClosed() method. Either update the builder to add AsClosed() (and ensure it maps to the actual domain state you intend) or revert this doc snippet to the existing AsArchived() API so the documentation matches the code.

Copilot uses AI. Check for mistakes.
.Build();

// Predefined scenario
var archivedIssue = IssueBuilder.Archived().Build();
var closedIssue = IssueBuilder.Closed().Build();
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IssueBuilder.Closed() is referenced here, but there is no Closed() static factory in tests/Unit/Builders/IssueBuilder.cs (it currently has Archived() instead). Please either add a Closed() factory (and keep it consistent with the instance method naming) or adjust the documentation to reference the existing factory method.

Copilot uses AI. Check for mistakes.
```

---
Expand Down
Loading