Bump yargs to v18.0.0#46578
Conversation
e02dad9 to
ce96e26
Compare
Netlify deploy previewhttps://deploy-preview-46578--material-ui.netlify.app/ Bundle size report
|
ce96e26 to
317eb7f
Compare
317eb7f to
a6be826
Compare
LukasTy
left a comment
There was a problem hiding this comment.
LGTM overall.
On mui-x this major has been used for quite a while.
However, I've checked that we didn't account for this being a direct dependency on the codemod package.
The minimum supported Node version is 20.19, whereas we declare support for >14.00 om the package. 🙈
So, technically, @mui/x-codemod is already lying about this...
material-ui/packages/mui-codemod/package.json
Lines 51 to 53 in cf0940b
WDYT @Janpot, should we avoid bumping this and potentially even downgrade the
yargs package on mui-x? 🤔
|
@Janpot Can you take a look? |
👍 I'm ok with bumping the engines field to match |
LukasTy
left a comment
There was a problem hiding this comment.
👍 I'm ok with bumping the engines field to match
yargs.
Ain't it a breaking change? 🤔
AFAIK, Olivier was adamant about keeping the engines.node as lenient as possible, but this is just about the codemod package. 🤷♂️
| "postcss": "^8.5.6", | ||
| "postcss-cli": "^11.0.1", | ||
| "yargs": "^17.7.2" | ||
| "yargs": "^18.0.0" |
There was a problem hiding this comment.
If we are fine with this slight BC, then this package engines.node field needs to be updated to >=20.19.
Not if it's already broken in practice. When did we upgrade to the
Personally, I don't see why we even put a restriction at all on our components packages. On our CLI tools I think it is desired to only support maintained versions of node.js. Even the most trivial dependency trees would have at least one dependency that restricts it to this version anyway. Note that technically, for packages like that we should also configure the corresponding |
e5c3f35 to
8d7e18e
Compare
Deploy previewhttps://deploy-preview-46578--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
8d7e18e to
83f7e8c
Compare
83f7e8c to
bd47a52
Compare
Janpot
left a comment
There was a problem hiding this comment.
Low risk of breaking, 98% of use-cases are just one-off migration runs, nobody would be hard blocked by this BC.
At the discretion of the maintainers to decide to merge or wait for v10. (If the latter please label it)
This PR contains the following updates:
17.7.2→18.0.0^17.7.2→^18.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
yargs/yargs (yargs)
v18.0.0Compare Source
⚠ BREAKING CHANGES
command.^20.19.0 || ^22.12.0 || >=23.Features
Bug Fixes
Code Refactoring
command. (d90af45)Build System
^20.19.0 || ^22.12.0 || >=23. (d90af45)Configuration
📅 Schedule: (in timezone UTC)
* 0-4 * * 7)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.