Skip to content

⬆️ update mqt-core#357

Merged
burgholzer merged 13 commits into
mainfrom
update-mqt-core
Jan 29, 2024
Merged

⬆️ update mqt-core#357
burgholzer merged 13 commits into
mainfrom
update-mqt-core

Conversation

@burgholzer

Copy link
Copy Markdown
Member

Description

This PR updates the mqt-core submodule and brings in some further advancements from #355.
Specifically, it switches to using FetchContent for obtaining mqt-core.
Per default, it is pointed to the vendored submodule via an overridable CMake variable.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added dependencies Pull requests that update a dependency file c++ Anything related to C++ code labels Jan 29, 2024
@burgholzer burgholzer self-assigned this Jan 29, 2024
@codecov

codecov Bot commented Jan 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6cc523) 96.3% compared to head (3a2cdb2) 96.1%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #357     +/-   ##
=======================================
- Coverage   96.3%   96.1%   -0.3%     
=======================================
  Files         34      34             
  Lines       1753    1754      +1     
  Branches     215     215             
=======================================
- Hits        1689    1686      -3     
- Misses        64      68      +4     
Flag Coverage Δ
cpp 95.8% <ø> (-0.3%) ⬇️
python 97.2% <ø> (ø)

see 2 files with indirect coverage changes

@burgholzer burgholzer merged commit 9870cce into main Jan 29, 2024
@burgholzer burgholzer deleted the update-mqt-core branch January 29, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant